Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature fix sorting of optimization results in presence of nan values, fixes #484 #691

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

jvanhoefer
Copy link
Member

Sorting of optimization values failed, when the objective function value is nan. nan is now treated as inf.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2021

Codecov Report

Merging #691 (9926083) into develop (f37f050) will increase coverage by 2.74%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #691      +/-   ##
===========================================
+ Coverage    87.60%   90.34%   +2.74%     
===========================================
  Files           96       96              
  Lines         6463     6466       +3     
===========================================
+ Hits          5662     5842     +180     
+ Misses         801      624     -177     
Impacted Files Coverage Δ
pypesto/result.py 89.28% <100.00%> (+0.60%) ⬆️
pypesto/engine/multi_process.py 92.59% <0.00%> (-7.41%) ⬇️
pypesto/objective/amici.py 84.23% <0.00%> (+0.98%) ⬆️
pypesto/objective/function.py 89.62% <0.00%> (+1.88%) ⬆️
pypesto/sample/geweke_test.py 94.36% <0.00%> (+2.81%) ⬆️
pypesto/objective/amici_calculator.py 93.33% <0.00%> (+5.00%) ⬆️
pypesto/objective/amici_util.py 84.21% <0.00%> (+10.52%) ⬆️
pypesto/optimize/optimizer.py 90.09% <0.00%> (+32.94%) ⬆️
pypesto/engine/mpi_pool.py 68.18% <0.00%> (+68.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f37f050...9926083. Read the comment docs.

@jvanhoefer jvanhoefer merged commit 16639a4 into develop Jul 2, 2021
@jvanhoefer jvanhoefer deleted the feature_fix_sorting branch July 2, 2021 13:07
@yannikschaelte yannikschaelte mentioned this pull request Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants