Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'raise' without Exception #696

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Fix 'raise' without Exception #696

merged 3 commits into from
Jul 15, 2021

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jul 8, 2021

and fix error message and simplify function. Fixes #633

and fix error message and simplify function. Fixes #633
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #696 (ccbd0c1) into develop (c58aaab) will increase coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #696      +/-   ##
===========================================
+ Coverage    90.08%   90.11%   +0.03%     
===========================================
  Files           96       96              
  Lines         6513     6513              
===========================================
+ Hits          5867     5869       +2     
+ Misses         646      644       -2     
Impacted Files Coverage Δ
pypesto/visualize/clust_color.py 91.25% <33.33%> (ø)
pypesto/sample/geweke_test.py 94.36% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c58aaab...ccbd0c1. Read the comment docs.

@dweindl dweindl requested a review from jvanhoefer July 8, 2021 17:11
@dweindl dweindl linked an issue Jul 8, 2021 that may be closed by this pull request
@dweindl
Copy link
Member Author

dweindl commented Jul 15, 2021

ping @jvanhoefer

@dweindl dweindl merged commit 3e0cc23 into develop Jul 15, 2021
@dweindl dweindl deleted the fix_633 branch July 15, 2021 11:12
@yannikschaelte yannikschaelte mentioned this pull request Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plain raises in clust_color
4 participants