updated store.ipynb. #699
Merged
updated store.ipynb. #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #699 +/- ##
===========================================
- Coverage 90.08% 89.91% -0.17%
===========================================
Files 96 96
Lines 6513 6513
===========================================
- Hits 5867 5856 -11
- Misses 646 657 +11
Continue to review full report at Codecov.
|
dilpath
approved these changes
Jul 9, 2021
Comment on lines
+562
to
+563
| "WARNING: You are loading a problem.\n", | ||
| "This problem is not to be used without a separately created objective.\n", |
There was a problem hiding this comment.
Is this still correct or fixed in develop? #669
There was a problem hiding this comment.
it is still correct, as we do not save the objective but rather just information of the objective.
doc/example/store.ipynb
Outdated
Comment on lines
334
to
348
| "print(\"History type: \", type(result.optimize_result.list[0].history))\n", | ||
| "# print(\"Function value trace of best run: \", result.optimize_result.list[0].history.get_fval_trace())\n", | ||
| "\n", | ||
| "fig, ax = plt.subplots(1, 2)\n", | ||
| "visualize.waterfall(result, ax=ax[0])\n", | ||
| "visualize.optimizer_history(result, ax=ax[1])\n", | ||
| "fig.set_size_inches((15, 5))" | ||
| ], | ||
| "execution_count": 7, | ||
| "outputs": [ | ||
| { | ||
| "name": "stdout", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "History type: <class 'pypesto.objective.history.CsvHistory'>\n" |
There was a problem hiding this comment.
This cell is identical to the previous cell? History type in the output is also CsvHistory.
yannikschaelte
approved these changes
Jul 9, 2021
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included HDF5 history and updated saving of results.