Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature load optimization result from history #726

Merged

Conversation

PaulJonasJost
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #726 (9682545) into develop (160c2a8) will decrease coverage by 54.44%.
The diff coverage is 25.34%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #726       +/-   ##
============================================
- Coverage    88.16%   33.72%   -54.45%     
============================================
  Files           79       97       +18     
  Lines         5257     6627     +1370     
============================================
- Hits          4635     2235     -2400     
- Misses         622     4392     +3770     
Impacted Files Coverage Δ
pypesto/engine/mpi_pool.py 0.00% <0.00%> (ø)
pypesto/ensemble/covariance_analysis.py 18.36% <0.00%> (-0.39%) ⬇️
pypesto/objective/aesara.py 0.00% <0.00%> (ø)
pypesto/objective/amici_calculator.py 25.00% <0.00%> (-66.67%) ⬇️
pypesto/optimize/__init__.py 100.00% <ø> (ø)
pypesto/petab/__init__.py 0.00% <0.00%> (ø)
pypesto/petab/importer.py 0.00% <0.00%> (-85.90%) ⬇️
pypesto/petab/pysb_importer.py 0.00% <0.00%> (-100.00%) ⬇️
pypesto/profile/profile.py 32.43% <0.00%> (-59.46%) ⬇️
pypesto/profile/util.py 23.40% <ø> (-72.35%) ⬇️
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a170bb...9682545. Read the comment docs.

Copy link
Contributor

@stephanmg stephanmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In read_from_hdf5.py the parameter filename is not documented. Return type annotation is missing as well. Besides this I think that the changes are fine.

Copy link
Contributor

@stephanmg stephanmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@PaulJonasJost PaulJonasJost merged commit 68d9452 into develop Oct 6, 2021
@PaulJonasJost PaulJonasJost deleted the feature_load_optimization_result_from_history branch October 6, 2021 14:41
@yannikschaelte yannikschaelte mentioned this pull request Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants