-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature load optimization result from history #726
Feature load optimization result from history #726
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #726 +/- ##
============================================
- Coverage 88.16% 33.72% -54.45%
============================================
Files 79 97 +18
Lines 5257 6627 +1370
============================================
- Hits 4635 2235 -2400
- Misses 622 4392 +3770
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In read_from_hdf5.py
the parameter filename
is not documented. Return type annotation is missing as well. Besides this I think that the changes are fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
No description provided.