Maybe fix history - result reconstruction mismatch #902
Conversation
yannikschaelte
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #902 +/- ##
===========================================
- Coverage 88.33% 86.53% -1.80%
===========================================
Files 107 107
Lines 7585 7613 +28
===========================================
- Hits 6700 6588 -112
- Misses 885 1025 +140
Help us with your feedback. Take ten seconds to tell us how you rate us. |
yannikschaelte
changed the title
There was a problem hiding this comment.
👍 CHI2 and SCHI2 are currently missing in all of the updates, but looking at #901, I would rather completely remove them than update the code.
| # in what is available. | ||
|
|
||
| # check if a useful history exists | ||
| # TODO Y This can be solved prettier |
There was a problem hiding this comment.
will leave for future refactoring ^^
| for a, b in zip(partial_trace, [full_trace[i] for i in arr]): | ||
| if var != 'schi2': | ||
| assert np.all(a == b) or np.isnan(a) and np.isnan(b) | ||
| assert np.all(a == b) or np.isnan(a) and np.isnan(b), var |
There was a problem hiding this comment.
assert_array_equal provides more helpful output than ==, but fine to leave, as those were there before.
Co-authored-by: Fabian Fröhlich <fabian_froehlich@hms.harvard.edu>
Co-authored-by: Fabian Fröhlich <fabian_froehlich@hms.harvard.edu>
👍 will make a separate pr removing chi2, schi2 |
Should fix #743.
Further