Remove dead code from DALiuGE #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were small experiments or utility modules that have no place in the current codebase. They are still available in our git history in case we need to check their contents. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
This set of scripts, Java code, CSV files and and jupyter notebook were used during the initial scalability benchmarks we ran in Pawsey and Tianhe-II back in 2016. These files have no place in our codebase though, so they are being removed in this commit. If anyone needs them they are in the git history. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
The core daliuge runtime code had some initial support for SHORE-stored data, but this was always very experimental and never saw any usage. This commit drops this support. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
This application drop was created only to satisfy a JIRA ticket sometime in the past, but in reality has no value. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
This application drop was initially written to demonstrate that we could use spead2 and daliuge (dfms at the time) together. This application has never seen usage however, its tests are always skipped, and therefore is simply dead code. If needed in the future, this code could be resurrected, although it's nothing special and can easily be reproduced (probably in a better shape). Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
These were used at some point, but only very briefly: in Jan 2017 they were added, and by May their usage was already commented out. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Except for testing, these schedulers were never publicly exposed to command-line or public API endpoints, and therefore have never been used outside local experiments. Removing them will cause no harm. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
davepallot
approved these changes
Jun 8, 2020
|
Thanks for the review @davepallot, I'll be merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits remove different pieces of dead code and artifacts from DALiuGE's runtime and translator packages. This includes:
fileimportapp drop, which was created only to satisfy a JIRA ticket a few years ago but otherwise has no valuespeadapp drop, which was written years ago to demonstrate how spead2 and daliuge (dfms at the time) could interact, but otherwise has seen no usage, and is often skipped even by the tests.Partitionsubclasses that lived in theschedulermodule only for a few months in 2017 and after that saw no further use.Schedulersubclasses, and supporting code, that have never seen the light of day via command-line options or public API endpoints. Some even didn't have unit tests, or were regularly skipped.After these changes the overall code coverage has gone up from ~70% to ~77%.