-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YAN-973 Nifty gridder testing #136
Conversation
tested nifty graphs
result: Optional[Number] = None | ||
combine = getattr(np, f"{self.functions[self.function]}") | ||
gather = getattr(np, f"{self.function}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a bug thats causing the the output image to be a single pixel..
COPY --from=0 /root/dlg /root/dlg | ||
|
||
RUN apt install -y wget gnupg2 software-properties-common | ||
RUN DEBIAN_FRONTEND=noninteractive apt install -y wget gnupg2 software-properties-common |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to match Dockerfile.dev. Basically cuda support is an extra docker build stage between common and engine, but there isn't a docker command to include a seperate dockerfile, only derive from an image
@@ -400,7 +402,7 @@ def averageArray(self): | |||
# \~English Specifies the number of times the 'run' method will be executed before finally giving up | |||
# @param[in] cparam/function Function/sum/Select/readwrite/False/sum,prod,min,max,add,multiply,maximum,minimum/False/ | |||
# \~English The function used for gathering | |||
# @param[in] cparam/function reduce_axes/None/String/readonly/False//False/ | |||
# @param[in] cparam/reduce_axes "Reduce Axes"/None/String/readonly/False//False/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
palette bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although I don't particularly like the dependency on the SKA repo. Had to happen at some point I guess...
RUN pip install dlg-nifty-components | ||
|
||
RUN pip install --extra-index-url=https://artefact.skao.int/repository/pypi-internal/simple 'ska-sdp-cbf-emulator[plasma]==1.6.11' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost overlooked this, but this should be updated to the newer sdp-realtime repositories, I'll do so after releasing the new version dlg-casacore-components to pypi then version locking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason some of the ska repositories are listed here is I can't to get a PyPi package to grab a dependency from the SKA package repo, it only works when the command pip install -r requirements.txt
is run
YAN-973 Nifty gridder testing
YAN-973 Nifty gridder testing
Done a fresh test with nifty gridding graphs and made a few necessary deployment changes and a bugfix on the gather component. As far as I can tell there is still not full support application paramaters, only component parameters so I've updated the daliuge derived palettes to use cparams