Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAN-973 Nifty gridder testing #136

Merged
merged 2 commits into from
Apr 8, 2022
Merged

YAN-973 Nifty gridder testing #136

merged 2 commits into from
Apr 8, 2022

Conversation

calgray
Copy link
Collaborator

@calgray calgray commented Apr 7, 2022

Done a fresh test with nifty gridding graphs and made a few necessary deployment changes and a bugfix on the gather component. As far as I can tell there is still not full support application paramaters, only component parameters so I've updated the daliuge derived palettes to use cparams

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.863% when pulling 57e7bbf on yan-973-nifty-testing into 226fab0 on master.

result: Optional[Number] = None
combine = getattr(np, f"{self.functions[self.function]}")
gather = getattr(np, f"{self.function}")
Copy link
Collaborator Author

@calgray calgray Apr 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bug thats causing the the output image to be a single pixel..

COPY --from=0 /root/dlg /root/dlg

RUN apt install -y wget gnupg2 software-properties-common
RUN DEBIAN_FRONTEND=noninteractive apt install -y wget gnupg2 software-properties-common
Copy link
Collaborator Author

@calgray calgray Apr 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to match Dockerfile.dev. Basically cuda support is an extra docker build stage between common and engine, but there isn't a docker command to include a seperate dockerfile, only derive from an image

@@ -400,7 +402,7 @@ def averageArray(self):
# \~English Specifies the number of times the 'run' method will be executed before finally giving up
# @param[in] cparam/function Function/sum/Select/readwrite/False/sum,prod,min,max,add,multiply,maximum,minimum/False/
# \~English The function used for gathering
# @param[in] cparam/function reduce_axes/None/String/readonly/False//False/
# @param[in] cparam/reduce_axes "Reduce Axes"/None/String/readonly/False//False/
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

palette bug

Copy link
Contributor

@awicenec awicenec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I don't particularly like the dependency on the SKA repo. Had to happen at some point I guess...

RUN pip install dlg-nifty-components

RUN pip install --extra-index-url=https://artefact.skao.int/repository/pypi-internal/simple 'ska-sdp-cbf-emulator[plasma]==1.6.11'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost overlooked this, but this should be updated to the newer sdp-realtime repositories, I'll do so after releasing the new version dlg-casacore-components to pypi then version locking

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason some of the ska repositories are listed here is I can't to get a PyPi package to grab a dependency from the SKA package repo, it only works when the command pip install -r requirements.txt is run

@calgray calgray merged commit 15d1583 into master Apr 8, 2022
awicenec pushed a commit that referenced this pull request May 19, 2022
pritchardn pushed a commit that referenced this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants