Fix problems with python 3.9 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been getting away with this code, but in reality we have always been guilty of not taking the GIL in the "pythonic" dynlibs (i.e., those offering a "init2" method rather than an "init" one). Until 3.8 no errors have showed up, but in 3.9 segfaults start to happen when calling PyLong_FromLong (and possibly other methods). To solve this I've updated our example code to take the GIL as appropriate. This is verbose, but it's the simples solution. A different approach would have been to load the dynlib with ctypes's PyDLL rather than CDLL, but that forces all C function calls to hold the GIL even if not required, which is less performant. Nobody (except Kevin, if he still does?) is using this anyway, and if so they would have run into the same error as we did here, so there's no issue in clarifying that the GIL must be taken by the dynlib code rather than by daliuge. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
This was found while stabilising the unit tests running against python 3.9, which in turn I was doing to have a stable basis to work against for YAN-968. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Now that the problems with 3.9 have been solved we should be able to test against it without problems. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
awicenec
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the main problems seen with python 3.9, and adds it back to the Travis build matrix.
There are still some stability problems with the unit tests around the multiprocessing support (one test runs out of file descriptors, and another leaves a dangling subprocess), but they are both currently circumvented (by chance!) in Travis, and they can also be easily avoided locally, so I'll leave those out for the time being as they require more work.