LIU-251 Add Pyfunc Port Parser Options #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyfunc update pyfunc default to pickle update test graphs
calgray
commented
May 20, 2022
| elif ptype in ["Python"]: | ||
| try: | ||
| import numpy | ||
| value = eval(value, {"numpy": numpy}, {}) |
There was a problem hiding this comment.
added numpy to scope as its currently used as default in some graphs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously pyfunc apps parsed both input and output drop contents using pickle or ast based on the pickle parameter. This however lead to the problem that a graph using only pyfunc apps either uses pickle everywhere or ast everywhere, so this change firstly split this param for all inputs and all outputs. Additionally I've changed the param to an enum type, namely one of pickle, ast, and path, however others can be added. Path is useful for functions that manually read from a file format by filename whilst at the same time using a filedrop.
rebase of #154
e.g.
