Liu 277 - Changing colour of expired and deleted drops #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Text of deleted drops is now light, so they can be read. Colour of expired drops are now a dark grey.
awicenec
approved these changes
Aug 15, 2022
awicenec
added a commit
that referenced
this pull request
Oct 10, 2024
Liu 277 - Changing colour of expired and deleted drops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR changes the colours of expired and deleted drops to a dark grey and black with white font respectively.
Additionally, this PR reduces the default garbage collection period to 30 seconds (down from 100).
Attached is an imaging showing deleted, expired and cancelled drops for reference.