Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move io to dlg.data #197

Merged
merged 7 commits into from
Aug 19, 2022
Merged

Move io to dlg.data #197

merged 7 commits into from
Aug 19, 2022

Conversation

pritchardn
Copy link
Collaborator

This PR moves the io.py file into dlg.data.
As a side-effect, to avoid circular imports, the data drops have been nested into a dlg.data.drops sub-module.

@coveralls
Copy link

coveralls commented Aug 18, 2022 •
edited

Coverage Status

Coverage decreased (-0.01%) to 82.126% when pulling 3086f4a on move-io into 1cd863c on master.

@pritchardn pritchardn marked this pull request as ready for review August 18, 2022 08:04
awicenec
awicenec approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@awicenec awicenec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As expected almost all changes are just imports

@awicenec awicenec merged commit 459e15d into master Aug 19, 2022
@awicenec awicenec deleted the move-io branch August 19, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awicenec awicenec awicenec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pritchardn @coveralls @awicenec