Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yan 1070 - add data_hash and signature attributes from BlockDAG to EAGLE palette JSON #204

Merged
merged 9 commits into from
Sep 30, 2022

Conversation

james-strauss-uwa
Copy link
Collaborator

Add data_hash and signature data generated by BlockDAG module into palettes JSON. I use build_block_dag() to generate data for the palette that is being built. It largely follows the example use of build_block_dag() from within the BlockDAG code.

From the BlockDAG data:

  • the "data_hash" attributes are copied to each component in the palette (as the attribute "dataHash")
  • the "signature" attribute for the whole set of components is copied into the palette (as the attribute "signature")

The additional information will be used in EAGLE to update components within existing graphs.

I'll create a PR for the associated EAGLE work soon.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 82.471% when pulling 76c56bc on yan-1070 into 28cd9d8 on master.

Copy link
Collaborator

@pritchardn pritchardn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me. Pulls the right info out from the BlockDAG stuff and it would be easy to add more fields which is handy.

@james-strauss-uwa james-strauss-uwa merged commit 92cfff7 into master Sep 30, 2022
@james-strauss-uwa james-strauss-uwa deleted the yan-1070 branch September 30, 2022 05:57
awicenec pushed a commit that referenced this pull request Oct 10, 2024
Yan 1070 - add data_hash and signature attributes from BlockDAG to EAGLE palette JSON
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants