Eagle 121 #53
Merged
Eagle 121 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d line and arguments will be stored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to EAGLE-121, the command line for a BashShellApp was specified using a set of parameters beginning with Arg. For example:
However, this caused issues when attempting to determine which arguments specified the command itself, the input redirection and the output redirection.
Some workflow systems (for example CWL) require these parts to be specified separately.
EAGLE-121 introduced default parameters in the BashShellApp for each part of the command line. This change to DALiuGE supports that change. The contents of additional named parameters is added to the final command line.
I've left the existing method (using Arg01, Arg02, etc) in the code. Since it is likely that only one of the two methods would be used. We have a large number of graphs that use the old method.