Added HTTP POST route (/gen_pgt) that will accept and translate a JSON logical graph submitted from EAGLE #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…N logical graph submitted from EAGLE.
rtobar
reviewed
Sep 5, 2019
There was a problem hiding this comment.
Looks great! Could you add a small unit test thought? I think that's why the coverage dropped. There are already some tests for this code under https://github.com/ICRAR/daliuge/blob/master/test/dropmake/test_lgweb.py so I would expect this not to be too difficult.
rtobar
reviewed
Sep 5, 2019
…_partition_with_params()). Fixed bug where json.loads() was called twice on incoming JSON because the string was not unescaped. Added unit test for new POST route.
…t hopefully works in python 2 and 3.
…oding that was not required.
|
Looking good! Merged now into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd be open to making any refinements you suggest.
The new function (gen_pgt_post) is similar to the existing one (gen_pgt). I've only factored out the duplicated list of translation algorithm parameters, since there was a minor inconsistency between the daliuge list and the eagle list ('max_load_imb').