Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIU-213 docker and plasma shared memory improvements #93

Merged
merged 4 commits into from
Jan 13, 2022
Merged

Conversation

calgray
Copy link
Collaborator

@calgray calgray commented Jan 11, 2022

In https://icrar.atlassian.net/browse/LIU-213 I noticed issues when writing large amounts of data to plasma stores. The primary issue was not allocating enough shared memory to plasma store container.

There is also a performance issue with plasmaIO is how previously bufferOutputStream uses a resizeable staging buffer before copying to plasma memory. Instead it is possible to create a fixed size plasma buffer and copy directly into it to improve drop performance in cases where drop size is known or only a single write is performed at runtime. To continue support of the old behaviour I've added a "use_staging" drop argument which indicates data will be copied to a resizeable buffer first before copying to plasma memory.

@coveralls
Copy link

coveralls commented Jan 11, 2022

Coverage Status

Coverage increased (+0.02%) to 79.227% when pulling 4b888fb on LIU-213 into c18936e on master.

@awicenec awicenec merged commit cc15b7d into master Jan 13, 2022
awicenec added a commit that referenced this pull request May 19, 2022
LIU-213 docker and plasma shared memory improvements
pritchardn pushed a commit that referenced this pull request May 20, 2022
LIU-213 docker and plasma shared memory improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants