feedbacks: convert json data to csv dump. #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #72 |
sohailrajdev97
requested changes
Dec 23, 2018
There was a problem hiding this comment.
The following changes are needed in this PR:
- The
Dump Feedbacksoption is showing up both infeedbacks-profandfeedbacks-adminportals. It should only show up infeedbacks-admin. (Or, optionally, add a feature which allows a professor to export his/her feedbacks) - Rename
Dump FeedbackstoExport Feedbacks - Add icons / image in the view where the export option is shown
- Name the exported files as
24x7-feedbacks-YYYY-MM-DD.csvandmidsem-feedbacks-YYYY-MM-DD.csv
|
resolved. |
| .mdl-grid | ||
| .mdl-layout-spacer | ||
| .mdl-cell.mdl-cell--4-col.mdl-card.mdl-shadow--2dp.profile-select(onclick="window.location.replace('#{rootURL}/#{reqPortal}/export/24x7')") | ||
| img.profile(src='/images/feedback/24.png') |
There was a problem hiding this comment.
Use a different image for the export link. Divide the view into two halves.
Upper half for:
- View 24x7 Feedbacks (Use existing image)
- Export 24x7 Feedbacks (Use a new import/export image)
Lower Half For
- View Mid-Semester Feedbacks (Use existing image)
- Export Mid-Semester Feedbacks (Use the new import/export image)
…ns to the export column.
…he option of export to feedbacks-prof.
|
Resolved. |
|
There is still a security issue with this PR. When exporting feedbacks from It should only contain the feedbacks received for currently logged in user. |
|
resolved. |
sohailrajdev97
approved these changes
Dec 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress