-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating black and rerunning it on all files #1388
Conversation
@lbianchi-lbl, why is black in |
Thanks for spotting that, I don't think there's any reason. I pushed a commit to remove the duplicated requirement, and another to update the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1388 +/- ##
==========================================
- Coverage 77.62% 77.62% -0.01%
==========================================
Files 391 391
Lines 64375 64375
Branches 14257 14257
==========================================
- Hits 49973 49970 -3
- Misses 11830 11834 +4
+ Partials 2572 2571 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the most part the formatting looks much cleaner now, I like that small expressions are consolidated into one or two lines instead of spaced out like before.
* Resolve CI failures from new version (1.20.4) of spellchecker (#1389) * Empty commit to verify failures on main * Resolve likely false positives * Resolve likely true positives * Resolve probable true positive * Remove "frst" from typos exclusions * Remove "ans" from typos exclusions b/c crate-ci/typos#981 * Fix target for 'fv' (flowsheet visualizer) reference (#1391) * outputs * fix hyperlink * put this back * put this back2 * replace with simple hyperlink * Updating black and rerunning it on all files (#1388) * Updating black and rerunning it on all files * Remove duplicated Black requirement * Update Black rev in pre-commit config --------- Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov> --------- Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov> Co-authored-by: Dan Gunter <dkgunter@lbl.gov> Co-authored-by: Keith Beattie <ksbeattie@lbl.gov>
Fixes
Replaces dependabot alert about black: #1381
Summary/Motivation:
Guess it's time to run this again
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: