Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix target for 'fv' (flowsheet visualizer) reference #1391

Merged
merged 14 commits into from
Apr 4, 2024

Conversation

dangunter
Copy link
Member

Fixes #1390

Summary/Motivation:

Hyperlink was changed

Changes proposed in this PR:

  • Fix the one place it is used

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.62%. Comparing base (923df9e) to head (b93e03d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
- Coverage   77.62%   77.62%   -0.01%     
==========================================
  Files         391      391              
  Lines       64375    64375              
  Branches    14257    14257              
==========================================
- Hits        49973    49970       -3     
- Misses      11830    11834       +4     
+ Partials     2572     2571       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbianchi-lbl lbianchi-lbl added the Priority:High High Priority Issue or PR label Apr 4, 2024
@lbianchi-lbl lbianchi-lbl merged commit 4e6a0f0 into IDAES:main Apr 4, 2024
30 checks passed
andrewlee94 added a commit that referenced this pull request Apr 10, 2024
* Resolve CI failures from new version (1.20.4) of spellchecker (#1389)

* Empty commit to verify failures on main

* Resolve likely false positives

* Resolve likely true positives

* Resolve probable true positive

* Remove "frst" from typos exclusions

* Remove "ans" from typos exclusions b/c crate-ci/typos#981

* Fix target for 'fv' (flowsheet visualizer) reference (#1391)

* outputs

* fix hyperlink

* put this back

* put this back2

* replace with simple hyperlink

* Updating black and rerunning it on all files (#1388)

* Updating black and rerunning it on all files

* Remove duplicated Black requirement

* Update Black rev in pre-commit config

---------

Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov>

---------

Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov>
Co-authored-by: Dan Gunter <dkgunter@lbl.gov>
Co-authored-by: Keith Beattie <ksbeattie@lbl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sphinx docs CI builds fail due to WARNING: external std:doc reference target not found: fv
2 participants