Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url to FBbi imaging method ontology #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dominikl
Copy link
Member

@dominikl dominikl commented Mar 2, 2023

Simply adds a link to the FBbi image method term. Like its done for Data DOI, Annotation File, etc.
/cc @francesw @sbesson

Screenshot 2023-03-02 at 13 59 14

I'm not sure if/how this can be transformed into using icons like it's done for the mapr annotations...

@sbesson
Copy link
Member

sbesson commented Mar 2, 2023

I thought I had opened a PR to that effect in the past but apparently not. To turn these URLs into icons, I think there are two things that need to happen:

1- split the value into separate keys (Imaging Method and Imaging Method URL) - see e.g. sbesson@07d577b
2- update the mapr configuration to register these keys and allow them to be processed together

If we decide to go down that route, I could imagine more of the keys under the idr.openmicroscopy.org/study/info namespace can be processed in the same way. This would definitely have some breaking implication for anyone who would parse these values by hand but long-term, it would be an improvements in terms of usability and searchability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants