Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to sql.py to get postgres working #292

Merged
merged 1 commit into from
May 20, 2018

Conversation

bensternlieb
Copy link
Contributor

Hi,

Running with

ex.observers.append(SqlObserver.create('postgresql://...

generated an error constructing the sqlalchemy schema. Some minor fixes seemed to make installation work.

Ran tox and all tests passed.

sacred version = "0.7.3"
Python 3.6.4
SQLAlchemy (1.2.7)
psycopg2 (2.7.4)
postgres server 9.6.6

@Qwlouse Qwlouse merged commit 576803a into IDSIA:master May 20, 2018
@Qwlouse
Copy link
Collaborator

Qwlouse commented May 20, 2018

Nice! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants