Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #445: Incompatibility with tensorflow-gpu #464

Merged
merged 2 commits into from
Apr 28, 2019

Conversation

tarik
Copy link
Contributor

@tarik tarik commented Apr 25, 2019

Problem:
Failing to read the version of import package tensorflow if distribution package tensorflow-gpu was installed.

Cause:
The version of the distribution package was retrieved rather than the version of the import package.

Solution:
Solving by actually importing the package and retrieving the version string.

…stribution package `tensorflow-gpu` was installed. Solving by actually importing the package and retrieving the version string.
@coveralls
Copy link

coveralls commented Apr 25, 2019

Coverage Status

Coverage remained the same at 83.936% when pulling ff1bb7f on tarik:tensorflow-gpu-fix into 40ac2bc on IDSIA:master.

Copy link
Collaborator

@JarnoRFB JarnoRFB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this so quickly! Just consider the comment for a minor change.

sacred/utils.py Outdated Show resolved Hide resolved
@JarnoRFB JarnoRFB merged commit 7263377 into IDSIA:master Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants