Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove decorator in ingredient.py #560

Merged
merged 10 commits into from
Aug 13, 2019
Merged

Remove decorator in ingredient.py #560

merged 10 commits into from
Aug 13, 2019

Conversation

gabrieldemarmiesse
Copy link
Collaborator

@gabrieldemarmiesse gabrieldemarmiesse commented Aug 2, 2019 •
edited
Loading

The current system with _gather and the decorator are quite complicated to understand. We can use a simpler inheritance mechanism to replace it.

@gabrieldemarmiesse gabrieldemarmiesse changed the title Remove decorator in ingredient.py [WIP] Remove decorator in ingredient.py Aug 2, 2019
@coveralls
Copy link

coveralls commented Aug 2, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.004%) to 85.302% when pulling 556ee1a on gabrieldemarmiesse:remove_decorator into 2b1e756 on IDSIA:master.

@gabrieldemarmiesse gabrieldemarmiesse changed the title [WIP] Remove decorator in ingredient.py Remove decorator in ingredient.py Aug 2, 2019
@Qwlouse Qwlouse self-requested a review August 2, 2019 23:48
@JarnoRFB
Copy link
Collaborator

lgtm

@gabrieldemarmiesse gabrieldemarmiesse merged commit e56ca37 into IDSIA:master Aug 13, 2019
@gabrieldemarmiesse gabrieldemarmiesse deleted the remove_decorator branch August 13, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qwlouse Qwlouse Awaiting requested review from Qwlouse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrieldemarmiesse @coveralls @JarnoRFB