Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less magic in the command lines options. #567

Conversation

gabrieldemarmiesse
Copy link
Collaborator

@gabrieldemarmiesse gabrieldemarmiesse commented Aug 5, 2019

From what I understand, subclassing CommandLineOption is not yet intended to be used by end users. I would like to take this chance to use less magic in the codebase, so that if we expose it in the API, it will be intuitive to users.

@gabrieldemarmiesse gabrieldemarmiesse marked this pull request as ready for review August 5, 2019 09:12
@coveralls
Copy link

coveralls commented Aug 5, 2019

Coverage Status

Coverage decreased (-0.03%) to 85.279% when pulling 5ecbe86 on gabrieldemarmiesse:less_magic_for_command_line into d3fe102 on IDSIA:master.

@JarnoRFB
Copy link
Collaborator

JarnoRFB commented Aug 6, 2019

Alas I believe this is already user facing https://sacred.readthedocs.io/en/latest/command_line.html?highlight=CommandLineOption#custom-flags . We might take a similar approach as with the host_info_gather decorator and make this an optional argument of Experiment.

@gabrieldemarmiesse
Copy link
Collaborator Author

gabrieldemarmiesse commented Aug 6, 2019

My bad. I'm really bad at searching in the docs.

We might take a similar approach as with the host_info_gather decorator and make this an optional argument of Experiment.

I'm totally in favor of that. It's way less magic than before. Now the question is how to transition without breaking everything.

@gabrieldemarmiesse
Copy link
Collaborator Author

Closing as this PR won't be merged unless there are major changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants