Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'force' option to disable suspicious changes warnings #97

Merged
merged 2 commits into from
Feb 18, 2016

Conversation

yk
Copy link
Contributor

@yk yk commented Feb 10, 2016

I often run quick experiments and change them by commenting/uncommenting stuff, often leaving me with "unused" parameters in the config file. The option --disable_suspicious_changes_warnings disables the warnings in that situation.

@Qwlouse
Copy link
Collaborator

Qwlouse commented Feb 15, 2016

Hey, thank you for the contribution! (and sorry for the delay)

I like the idea of having a flag for that usecase. But --disable_suspicious_changes_warnings is a bit too verbose for my taste. Also the shorthand for that -d is already taken by `--debug``.

How would you feel about naming it --force/-f instead? The intuition being the same as for rm -f: "Just do it! I know what I'm doing."

@yk yk changed the title added an option to disable suspicious changes warnings added 'force' option to disable suspicious changes warnings Feb 17, 2016
@yk
Copy link
Contributor Author

yk commented Feb 17, 2016

I've changed the name now, but I haven't had the chance to extensively test this new version.

@Qwlouse
Copy link
Collaborator

Qwlouse commented Feb 18, 2016

Cool thanks!

Qwlouse added a commit that referenced this pull request Feb 18, 2016
added 'force' option to disable suspicious changes warnings
@Qwlouse Qwlouse merged commit 79ee926 into IDSIA:master Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants