feat(comp: result): add result component #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
之前API设计时 |
Codecov Report
@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 96.24% 96.38% +0.14%
==========================================
Files 50 55 +5
Lines 773 803 +30
Branches 141 144 +3
==========================================
+ Hits 744 774 +30
Misses 11 11
Partials 18 18
Continue to review full report at Codecov.
|
danranVm
requested changes
Jan 13, 2021
LaamGinghong
force-pushed
the
feature/result
branch
from
b9118f9
to
affc877
Compare
|
所以less的变量是全局的？我完全没有引用icon的样式居然也可以用里面的变量 |
|
@danranVm 请重新review |
对的，它没有 module 一说。 |
我靠，但是ide在没有引用的情况下报了警告 |
danranVm
reviewed
Jan 14, 2021
danranVm
approved these changes
Jan 14, 2021
LaamGinghong
force-pushed
the
feature/result
branch
from
564a702
to
f864651
Compare
|
@danranVm 已合并成一个commit |
|
@huangtenghui review 一下 |
|
感谢PR, LGTM. |
CruellyJoHn
pushed a commit
to CruellyJoHn/components
that referenced
this pull request
Jan 22, 2021
fix IDuxFE#77 build: upgrade vite (IDuxFE#102) refactor(comp:all): updalte all components ts definition (IDuxFE#103) docs: update all components index.zh.md (IDuxFE#105) * docs: update gen script fix(comp: divider): dynamic slot (IDuxFE#104) fix IDuxFE#76 feat(comp: spin): add spin component (IDuxFE#101) fix IDuxFE#72 refactor(comp:core): useGlobalConfig (IDuxFE#107) fix: vite traverse filename config (IDuxFE#106) docs: update spin component demo (IDuxFE#109) fix(comp: divider): slots rerender (IDuxFE#110) refactor(comp:i18n): update useI18n to useLocale (IDuxFE#111) feat(comp: space): add component space (IDuxFE#97) fix IDuxFE#63 fix(comp:all): solot dynamic load (IDuxFE#114) fix: add engines to package.json (IDuxFE#117) yarn start error because of the low version of Node.js fix IDuxFE#116 refactor: script gen type structure (IDuxFE#118) refactor: script gen types template (IDuxFE#119) * Update the template to make it more simpler. style(scripts): add brace style eslint rule (IDuxFE#123) fix IDuxFE#122 refactor(comp:all): export type declaration from current component (IDuxFE#124) docs: contribution (IDuxFE#125) update contributing.zh and add contributing.en fix(comp: image): export type to fix vite error (IDuxFE#127) feat(cdk:forms): add useFormControl and Validtors (IDuxFE#121) * test(cdk:forms): add test fix IDuxFE#115 docs(cdk:forms): add validators docs (IDuxFE#128) re IDuxFE#115 docs: modify components' docs' type (IDuxFE#131) feat(comp: empty): add component empty (IDuxFE#132) * feat(comp:empty): update and add test fix IDuxFE#54 feat(cdk:utils): add hasOwnProperty function (IDuxFE#137) fix(comp: badge): overflowCount not work (IDuxFE#135) fix IDuxFE#134 test(comp:badge,icon): fix warning (IDuxFE#140) feat(comp: result): add result component (IDuxFE#136) fix IDuxFE#112 feat(cdk:forms): add formGroup and formArray (IDuxFE#139) * feat(cdk:forms): add test re IDuxFE#115 feat(cdk:forms): add utils (IDuxFE#141) re IDuxFE#115 refactor(cdk:forms): `modelRef` renamed to `valueRef` (IDuxFE#142) re IDuxFE#115 feat(cdk:forms): add watchValue and watchStatus (IDuxFE#143) re IDuxFE#115 refactor(cdk:forms): add dirty status and marks `valueRef` to readonly (IDuxFE#144) re IDuxFE#115 feat(cdk:forms): setValue support configuration options (IDuxFE#146) re IDuxFE#115 feat: add global types (IDuxFE#150) docs(cdk:forms): add docs and demo (IDuxFE#149) fix IDuxFE#115 refactor(cdk:forms): update typescript defintions (IDuxFE#151) * docs(cdk:forms): update docs feat(cdk: subject): add subject (IDuxFE#155) fix IDuxFE#154 feat(comp: typography): add directive typography (IDuxFE#148) * docs(comp: typography): modify docs * feat(comp: typography): add type check * feat(comp: typography): style * test(comp: typography): add test fix IDuxFE#130 feature(comp:card): 1.修改dom结构 2.补全css样式 3.重跑单测 feat(comp:card): 1.解决合并冲突 feat(comp:card): add card component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #112
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Other information