Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:pagination): add pagination component #339

Merged
merged 1 commit into from
Jun 4, 2021
Merged

feat(comp:pagination): add pagination component #339

merged 1 commit into from
Jun 4, 2021

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Jun 4, 2021

fix #98

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Jun 4, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #339 (c63758d) into main (213a438) will increase coverage by 0.11%.
The diff coverage is 99.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   94.43%   94.54%   +0.11%     
==========================================
  Files         165      175      +10     
  Lines        5120     5334     +214     
  Branches      826      855      +29     
==========================================
+ Hits         4835     5043     +208     
- Misses        285      291       +6     
Impacted Files Coverage Δ
packages/cdk/virtual-list/src/list.tsx 96.00% <ø> (ø)
packages/cdk/virtual-list/src/types.ts 66.66% <ø> (ø)
packages/components/i18n/src/locales/en-US.ts 100.00% <ø> (ø)
packages/components/i18n/src/locales/zh-CN.ts 100.00% <ø> (ø)
packages/components/icon/src/staticIcons.ts 100.00% <ø> (ø)
packages/components/select/src/OptionContainer.vue 94.11% <0.00%> (-5.89%) ⬇️
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/pagination/src/Default.vue 100.00% <100.00%> (ø)
packages/components/pagination/src/Jumper.vue 100.00% <100.00%> (ø)
packages/components/pagination/src/Simple.vue 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 213a438...c63758d. Read the comment docs.

@danranVm danranVm merged commit d6aedf5 into IDuxFE:main Jun 4, 2021
@danranVm danranVm deleted the feat-pagination branch June 4, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp: Pagination] add Pagination component
1 participant