Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:input-number): add input-number component #584

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

imguolao
Copy link
Contributor

@imguolao imguolao commented Dec 7, 2021

fix #31

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Dec 7, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #584 (9c61dfe) into main (eeba516) will increase coverage by 0.20%.
The diff coverage is 95.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
+ Coverage   83.44%   83.64%   +0.20%     
==========================================
  Files         325      333       +8     
  Lines        8328     8510     +182     
  Branches     1867     1905      +38     
==========================================
+ Hits         6949     7118     +169     
- Misses       1379     1392      +13     
Impacted Files Coverage Δ
packages/cdk/portal/index.ts 100.00% <ø> (ø)
packages/components/affix/src/types.ts 100.00% <ø> (ø)
packages/components/anchor/src/types.ts 100.00% <ø> (ø)
packages/components/back-top/src/types.ts 100.00% <ø> (ø)
packages/components/drawer/src/DrawerWrapper.tsx 79.85% <ø> (ø)
packages/components/drawer/src/types.ts 100.00% <ø> (ø)
packages/components/icon/src/dependencies.ts 100.00% <ø> (ø)
packages/components/modal/src/types.ts 100.00% <ø> (ø)
packages/components/popconfirm/src/token.ts 100.00% <ø> (ø)
packages/components/popconfirm/src/types.ts 100.00% <ø> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed211eb...9c61dfe. Read the comment docs.

const { class: className, style, ...rest } = attrs
return (
<span class={classes.value} style={style as StyleValue}>
<IxInput
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其实我不是很想,所有的组件的输入框都用 IxInput 来实现,用原生的 input 更好。

这个可以先不改,后面再看吧,

packages/components/input-number/src/types.ts Show resolved Hide resolved
packages/components/input-number/src/types.ts Outdated Show resolved Hide resolved
packages/components/input-number/src/types.ts Outdated Show resolved Hide resolved
packages/components/input-number/src/InputNumber.tsx Outdated Show resolved Hide resolved
@danranVm danranVm merged commit 198381c into IDuxFE:main Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp: inputNumber]feature inputNumber component
2 participants