Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(comp:list): rebuild with tsx (#187) #856

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

qingshan-dev
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Apr 23, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #856 (c80fdaf) into main (5c6ee77) will decrease coverage by 0.00%.
The diff coverage is 99.47%.

@@            Coverage Diff             @@
##             main     #856      +/-   ##
==========================================
- Coverage   93.66%   93.65%   -0.01%     
==========================================
  Files         647      645       -2     
  Lines       62994    62915      -79     
  Branches     7696     7705       +9     
==========================================
- Hits        59004    58924      -80     
- Misses       3990     3991       +1     
Impacted Files Coverage Δ
packages/components/list/src/List.tsx 98.78% <98.78%> (ø)
packages/components/list/__tests__/list.spec.ts 100.00% <100.00%> (ø)
...ackages/components/list/__tests__/listItem.spec.ts 100.00% <100.00%> (ø)
packages/components/list/src/Item.tsx 100.00% <100.00%> (ø)
packages/components/list/src/token.ts 100.00% <100.00%> (ø)
packages/components/list/src/types.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c6ee77...c80fdaf. Read the comment docs.

Copy link
Contributor Author

@qingshan-dev qingshan-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self check is finish

packages/components/list/src/List.tsx Outdated Show resolved Hide resolved
packages/components/list/src/List.tsx Outdated Show resolved Hide resolved
Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danranVm danranVm merged commit 56db6f8 into IDuxFE:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants