Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country Pages [Feedback and Issues] #360

Open
35 of 37 tasks
udaynwa opened this issue Dec 15, 2023 · 45 comments
Open
35 of 37 tasks

Country Pages [Feedback and Issues] #360

udaynwa opened this issue Dec 15, 2023 · 45 comments
Assignees
Labels
discussion This issue or pull request is open for general discussion type: bug Something isn't working

Comments

@udaynwa
Copy link

udaynwa commented Dec 15, 2023

Ticket description

If you find issues or have any feedback on the Country Pages, please add them in the comments. While commenting, please add them with Task list/ checkboxes (and with screenshots and URLs if possible).

Post-release changes

Hide PII in Local Units Information

Add Wiki hook points (29th April)

Additional changes (22nd April)

Feedback from Daniel added in the comments of #492

Commented by Daniel (4th March)

Additional feedback by Daniel (4th March)

Additional feedback (12th March)

26th March

Based on #360 (comment)

8th April

17th April (Based on feedback from Mariam & Alex)

@samshara samshara added the type: bug Something isn't working label Dec 15, 2023
@udaynwa udaynwa added the discussion This issue or pull request is open for general discussion label Dec 18, 2023
@udaynwa udaynwa mentioned this issue Jan 23, 2024
26 tasks
@udaynwa udaynwa self-assigned this Jan 25, 2024
@tovari
Copy link

tovari commented Feb 26, 2024

@udaynwa, When it is deployed to staging, would you mind to provide the dev and english string list to make the translations to es, fr and ar?

@tovari
Copy link

tovari commented Feb 26, 2024

@udaynwa, can we also have a list of external sources implemented on country pages? Those will need to be added to the monitoring page. Thanks!

@barshathakuri
Copy link
Collaborator

barshathakuri commented Feb 27, 2024

@udaynwa, can we also have a list of external sources implemented on country pages? Those will need to be added to the monitoring page. Thanks!

Hi @tovari, These are the lists of external sources implemented on country pages for each component:

cc: @udaynwa

@tovari
Copy link

tovari commented Mar 4, 2024

We will need to redirect the old tab urls to the new structure:

Old url New url
/operations /ongoing-activities/emergencies
/three-w/projects /ongoing-activities/three-w/projects
/three-w/ns-projects /ns-overview/activities
/risk-watch /profile/risk-watch
/preparedness /ns-overview/capacity
/plan /ns-overview/strategic-priorities
/additional-info /additional-info

@udaynwa
Copy link
Author

udaynwa commented Mar 5, 2024

@tovari , your feedbacks on Country Pages have been incorporated and pushed to Staging as well. (except for the redirection to the new structure).

cc @samshara @frozenhelium

@frozenhelium
Copy link
Member

@tovari There was an issue in the previous version (v7.1.0) which is now fixed in the (v7.1.1)

@tovari
Copy link

tovari commented Mar 5, 2024

A few things to improve:

@udaynwa
Copy link
Author

udaynwa commented Mar 6, 2024

@tovari

we shouldn't have GDACS events as emergencies. Not sure why do we generate emergencies from GDACS alerts

  • For this, this was in the Figma prototype. Therefore, we implemented a new API to fetch GDACS events, and created the view to show them. Should we remove this section altogether?

Active Operations under Ongoing Activities - Ongoing Emergencies doesn't show ongoing operations like https://go-stage.ifrc.org/emergencies/6647/details or https://go-stage.ifrc.org/emergencies/6646/details

Ongoing Activities - 3W Projects -> All Projects above the map (left side) should be renamed to Ongoing Projects

  • We will create a ticket and implement it.

Country profile - Overview: Missing data should be indicated by '-' as in most places except for Pop under 18 : https://go-stage.ifrc.org/countries/119/profile/overview

  • We will create a ticket and implement it.

cc @barshathakuri @samshara

@tovari
Copy link

tovari commented Mar 6, 2024

Country profile - Overview: Missing data should be indicated by '-' as in most places except for Pop under 18 : https://go-stage.ifrc.org/countries/119/profile/overview

might be misleading. I mean we should have '-' at Pop under 18 as well.

@steph-gm
Copy link

steph-gm commented Mar 6, 2024

NS Preparedness

  • National Society Overview - Capacity - NS Preparedness and Response Capacity: For the public (not logged in), the NS Preparedness and Response Capacity Section should be visible, just like when logged-in with the specific permissions, since the info in the cards is not private:
image

However, once clicking on "view" inside these cards, the next page (of the specific cycle) should change according to the permissions. If public (not logged in), they should see something like the one that is already on Production, with limited access:
image

  • National Society Overview - Strategic Priorities - NS Strategic Priorities: Similar than the above, for the public (not logged in), the PER info under the NS Strategic Priorities Section should be visible, just like when logged-in with the specific permissions, since this info is not private:
image image

@tovari
Copy link

tovari commented Mar 11, 2024

  • NS Overview - Capacity - Organisational Capacity: this needs to be removed for now (not approved yet for publication)
  • Missing data - more details needed and improve language
  • Map legends are missing
  • Data source indication / precise data source indications missing
  • Country Profile - Previous events - Previous Events timeline: this seems another version of the 'Emergencies over month' diagram. On Figma, the data is rather presented by year
  • Country Profile - Previous events - Emergencies over month: It seems there are missing data from the diagram. E.g.: https://go-stage.ifrc.org/countries/136/profile/previous-events misses emergencies from March, May, August if filtered on the last 5 years. Past events diagram shows the missing emergencies

@udaynwa
Copy link
Author

udaynwa commented Mar 12, 2024

@tovari @steph-gm , thank you for adding your feedback. We are looking into them.

@tovari
Copy link

tovari commented Mar 20, 2024

@frozenhelium, @samshara I'm sharing the translation strings here

country_pages_translations-240319.xlsx

@mariam-yu
Copy link

mariam-yu commented Mar 20, 2024

@tovari @udaynwa @frozenhelium Some updates to the country wires were requested. The wires have been updated (pending a final glance through by Alex). We still need to update the UI. The list of changes below so that they are easier to locate. Thanks!
https://www.figma.com/proto/H9mZfGeXtlzK6HPzttYoci/IFRC-GO---Wires-Current---1?page-id=0%3A1&type=design&node-id=82-25714&viewport=11515%2C13586%2C0.14&t=Xv4cL6Q8FXtpcEBz-1&scaling=scale-down-width&starting-point-node-id=1%3A10724&hide-ui=1

Country changes list:


1 - NS overview > NS activities:

  • Update text on top
  • NSD Fund modules moves to hear from Context & Structure with updated title and module cards. Note: For NSIA fund type, since they don’t have categories (yet), they would like instead to have the funding type referring to Accelerator or Bride. (Card updated UI pending)

2 - NS overview > Context & Structure:

  • As per above, remove the NSD Fund module from here
  • On Income Source Breakdown add on hover text for the categories (e.g. government) from FDRS (CC @alex). No need to tooltip icon, as then visually they will be many.
    - Just FYI, we are considering merging NS director and Contacts and extending the Local units map, but these updates will come with the local units updates (as needs some redesign).

3. NS overview > Strategic Priorities:

  • Updated top text
  • Tooltip next to title "Strategic priorities" to explain what those are.

4. NS overview > Capacity:

  • Removed the Organisation Capacity section and moved to the Future file, since per Alex this is not ready yet.
  • Updated title for OCAC/BOCA section
  • Update slightly the styling of the cards (UI pending)

5. NS overview > Supporting Partners:

  • Moving the Supporting Partners tab form Country to NS overview
  • Adding a tooltip next to title "Membership Coordination" to explain that the section comes to Unified Planning and details.

5. Country Profile > Supporting Partners:

  • As per above, removing the Supporting Partners from Country Profile section completely.

6. Update text

  • Update the sub-header text across.

@mariam-yu
Copy link

Here is the info for Point 2, bullet 2 from the above - hover texts (from @AlexxxH ):

• Home Government: (in pdf blank, no hover needed)
• Foreign Government: Other governments and government departments from outside the country. This
includes the EU. Examples are: UK (DFID/FCO), US (USAID/OFDA/OTI/PRM), Sweden (SIDA) etc.
• Individuals: Members of the public, including funds from membership, major donors and legacies.
• Corporations: Including donations, proceeds from joint promotions or sponsorship.
• Foundations: Funds from a "not for profit" set up with the explicit aim of making donations to other
organisations (e.g., Charities Aid Foundation). This includes foundations established by corporations or
individuals (e.g., Lebara Foundation and Bill & Melinda Gates Foundation).
• UN Agencies and other Multilateral Agencies: These include the development institutions of the UN
(e.g., UNDP), the World Bank, Global Fund and regional development banks.
• Pooled funds: Mechanisms used to receive contributions from multiple financial partners (mainly
government donors) and allocate such resources to multiple implementing entities. Humanitarian pooled
funds can be global (the START Fund) or country-based (e.g., the CHF, ERF).
• Non-governmental organizations: Local and international "not for profit" civil society organizations
independent from states and international governmental organizations.
• Service income: Income linked to the provision of public services; for example, blood, hospital or
ambulance services, search and rescue, etc.
• Income generating activity: Income linked to the sale of a product or service; for example, commercial
first aid training, retail, sale and/or rental of other products and services.
• Other National Society: (in pdf blank, no hover needed)
• IFRC (HQ, regional and countries delegations): (in pdf blank, no hover needed)
• ICRC: (in pdf blank, no hover needed)
• Other: Income that does not come from any of the above categories.

@samshara
Copy link
Member

@mariam-yu, for the following tasks, we need the tooltip descriptions. Right now we don't see any.

  • Tooltip next to title "Strategic priorities" to explain what those are.
  • Adding a tooltip next to title "Membership Coordination" to explain that the section comes to Unified Planning and details.

@mariam-yu
Copy link

@AlexxxH Do you have any idea for the above? I guess a one-liner to explain what the SPs are and that they come from the UP. I'd put the same popup for both tooltips.

@AlexxxH
Copy link

AlexxxH commented Mar 28, 2024

@mariam-yu Hmm no I don't know, I'll ask Rania

@tovari
Copy link

tovari commented Apr 5, 2024

Thanks for the updates, I discovered some issues:

@samshara
Copy link
Member

samshara commented Apr 8, 2024

@tovari

  • NS Overview - NS Acitivies: the map shows domestic projects instead of International projects of the NS

we fetch the projects using the following query
https://goadmin-stage.ifrc.org/api/v2/project/?limit=9999&reporting_ns=81
Here, we use the reporting_ns query parameter to determine the international projects of a particular National Society (NS). The above situation arises when some projects are operated within the same National Society.

We could proceed with the following two ways

  1. Keep the view as it is and perhaps change the heading from 'NS International Activities' to 'NS Activities' to accurately reflect the data.
  2. Remove the projects that are operated within the same National Society. This will also mean that these projects won't be visible.

How do we proceed?

@AlexxxH
Copy link

AlexxxH commented Apr 10, 2024

@samshara @tovari @mariam-yu I would suggest the first option, so that we can keep domestic activities?

@tovari
Copy link

tovari commented Apr 10, 2024

Ok, lets rename it to 'NS Activities'

@mariam-yu
Copy link

@

@samshara @tovari @mariam-yu I would suggest the first option, so that we can keep domestic activities?

@samshara @tovari @AlexxxH I think we had renamed it to NS Activities sometime back. Wires for reference: https://www.figma.com/file/H9mZfGeXtlzK6HPzttYoci/IFRC-GO---Wires-Current---1?type=design&node-id=82-30343&mode=design&t=0aM4N0RARK3shjGg-4

@samshara
Copy link
Member

@

@samshara @tovari @mariam-yu I would suggest the first option, so that we can keep domestic activities?

@samshara @tovari @AlexxxH I think we had renamed it to NS Activities sometime back. Wires for reference: https://www.figma.com/file/H9mZfGeXtlzK6HPzttYoci/IFRC-GO---Wires-Current---1?type=design&node-id=82-30343&mode=design&t=0aM4N0RARK3shjGg-4

@mariam-yu I believe we need to appropriately rename the map section heading and the table heading as well.

@AlexxxH
Copy link

AlexxxH commented Apr 19, 2024

Hi everyone, here are the requested updates. The list looks long but that is (partly) becuase I strcutured it by section. Let me know if anything is unclear or you need more information. Thanks!

Sources - updating text and links:

Page-specific updates:

  • National Society Overview:
    • NS Activities: change description which is currently “The following data displays the activities of the National Society which include emergency or non-emergency related projects, as well as ongoing and implemented/closed initiatives funded by the different NSD funding mechanisms. The displayed data is based on reporting and may not be fully indicative of all the activities.”
      to the following:
      ”The following data displays international and domestic activities of the National Society reported through GO, which may include emergency and non-emergency related projects. The displayed data is based on reporting and so may not include all the activities of the National Society.”
    • Context and Structure:
    • Strategic priorities:
      • “NS Strategic Priorities”: Rename document links as follows, (e.g. for Angola): “Angola Country Plan” → “IFRC Network Plan”, and “Angola Internal Plan” → “Unified Plan”
      • “NS Strategic Priorities”: Rename the first five Strategic Priorities in the table to: “Climate and environment”, “Disasters and crises”, “Health and wellbeing”, “Migration and displacement”, “Values, power and Inclusion”
    • Capacity:
      • "Organisational Capacity Assessments”: remove “View details” buttons from the OCAC and BOCA boxes
    • Supporting partners:
      • Remove top “Go to IFRC” button
      • “IFRC Presence”: Add “Office type” (field “officetype” in the API response) (e.g. “Headquarters”, “Regional Office”, “Country Cluster”, “Representative Office”), and location (field “city” in the API response)
      • “IFRC Presence”: Disaster law information seems to be greyed out for all countries, even where there is an IFRC disaster law page. Is this a bug?
        When this data isn’t available, is it possible to hide instead of greying it out?
      • “Membership coordination”: remove “Engaged”, “Accountable”, and “Trusted”, and instead add “Enabling functions”. Therefore the total list should be: “Climate”, “Crisis”, “Health”, “Migration”, “Inclusion”, and “Enabling functions”.

GO generic:

  • "Data not available" - is it possible to improve the messaging? Can we discuss?
  • Missing data. E.g. for the seasonal calendar, can we hide this box where there is not data (e.g. for [Argentina](https://go-stage.ifrc.org/countries/20/profile/overview))? Is it possible to do something about this? Can we discuss?
  • Rounding. E.g. for “NS Overview” → “Context and Structure” → “National Society indicators”.
    Suggestion is to only round if the number is greater than 1000, and in this case use the normal GO rounding rules.

@udaynwa
Copy link
Author

udaynwa commented Apr 25, 2024

Risk Watch:
Where there is not a source, please set the source to ""IFRC Montandon, Global Crisis Data Bank" (no link).

@AlexxxH , do we add the source information to every section in the Risk Watch?

cc @tovari @mariam-yu

@AlexxxH
Copy link

AlexxxH commented Apr 25, 2024

@udaynwa Yes please, but currently (based on the wireframes) the only sections without a source on the Risk Watch page are Average Risks by Month and Expected Return Periods

@samshara
Copy link
Member

samshara commented Apr 25, 2024

@AlexxxH , also, we are missing the source link for Risks by Months section. Can you please share them here?

@AlexxxH
Copy link

AlexxxH commented Apr 25, 2024

@samshara there are sources for this section in the wireframes (screenshot below), @mariam-yu are these still correct?
image

@samshara
Copy link
Member

@AlexxxH , Thanks. However, I don't know what URLs we use for the above sources ? The URLs are not attached in the figma file as well.

cc @mariam-yu

@mariam-yu
Copy link

Hey guys @AlexxxH @samshara @udaynwa the sources are not accurate in the wires yet. Let me update them this afternoon based on the chat with Alex. Otherwise, the wires are good to go. We are updating the UI.

@mariam-yu
Copy link

Hey guys @AlexxxH @samshara @udaynwa the sources are not accurate in the wires yet. Let me update them this afternoon based on the chat with Alex. Otherwise, the wires are good to go. We are updating the UI.

@udaynwa Country wires are up to date. UI in process. All the sources added. Let me know if you have any questions. @AlexxxH Let me know if we missed anything. Thanks!

https://www.figma.com/proto/H9mZfGeXtlzK6HPzttYoci/IFRC-GO---Wires-Current---1?page-id=0%3A1&type=design&node-id=82-25714&viewport=22827%2C23425%2C0.29&t=wNULCOt1mZY2WQzb-1&scaling=scale-down-width&starting-point-node-id=1%3A10724&hide-ui=1

@samshara
Copy link
Member

image

Thanks for the quick updates on wires @mariam-yu.
Is the source information in the above correct?

@mariam-yu
Copy link

@samshara I think so. Per @AlexxxH for all the risk stuff we should put crisis data bank without a link. @AlexxxH I think this was per chat with Justin. Is it ok to already put them like this? I added to all the risk tables.

@tovari
Copy link

tovari commented Apr 26, 2024

Would you mind to add Wiki hook points on each page (sub-tab) as listed here? The icon could be located as usual on the right side.

PROD page url En | Wiki url EN
/countries/XXX/ongoing-activities/emergencies | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#on-going-activities
/countries/XXX/ongoing-activities/three-w/projects | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#h-3w-projects
/countries/XXX/ns-overview/activities | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#national-society-overview
/countries/XXX/ns-overview/context-and-structure | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#context-and-structure
/countries/XXX/ns-overview/strategic-priorities | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#strategic-priorities
/countries/XXX/ns-overview/capacity | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#capacity
/countries/XXX/ns-overview/supporting-partners | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#partners
/countries/XXX/profile/overview | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#country-profile
/countries/XXX/profile/risk-watch | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#risk-watch
/countries/XXX/profile/previous-events | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#previous-events
/countries/XXX/profile/additional-info | https://go-wiki.ifrc.org/en/user_guide/Country_Pages#additional-data

@davidmuchatiza
Copy link

davidmuchatiza commented Apr 29, 2024

image

There is a need to update the local units' information on the tooltip (both on the local units and health sites map) to exclude personal identifiable information, as the local unit map will be accessed by users who are not logged in. And here is the ticket

@tovari
Copy link

tovari commented Apr 29, 2024

image There is a need to update the local units' information on the tooltip (both on the local units and health sites map) to exclude personal identifiable information, as the local unit map will be accessed by users who are not logged in. [And here is the ticket](https://github.com//issues/896)

@davidmuchatiza, only for the public access, or also for logged-in users?

@davidmuchatiza
Copy link

image There is a need to update the local units' information on the tooltip (both on the local units and health sites map) to exclude personal identifiable information, as the local unit map will be accessed by users who are not logged in. [And here is the ticket](https://github.com/[/issues/896](https://github.com//issues/896))

@davidmuchatiza, only for the public access, or also for logged-in users?

For all the users for now, then maybe later on we can add more details for Logged-in users..

@davidmuchatiza
Copy link

Local Unit map tooltip title is using local names (Name_LOC), but we have some local units where only english names (Name_EN) are available and there's no local name provided. I'd like to suggest a solution to continue using Local names (Name_LOC) where available, but if they're blank, we should display the english names (Name_EN) instead. @udaynwa

@justinginnetti
Copy link

Small fixes:

Screenshot 2024-04-30 at 11 35 57 At the moment, the text here should read: "Source: UNDRR, World Bank/GFDRR and IDMC"

@justinginnetti
Copy link

justinginnetti commented Apr 30, 2024

Small fix. The text should read:
"Sources:
INFORM for each country's level of risk
UNDRR for the population exposure
IDMC for the expected displacements
IPC for food insecurity"
Screenshot 2024-04-30 at 11 41 03

@justinginnetti
Copy link

Small fix. It should read:

"Sources:
INFORM for each country's level of risk
UNDRR for the population exposure
IDMC for the expected displacements
IPC for food insecurity"

Screenshot 2024-04-30 at 11 41 51

@tovari
Copy link

tovari commented May 1, 2024

@udaynwa, there is an error when loading the NS Overview -> Partners page (e.g. here:
https://go.ifrc.org/countries/206/ns-overview/partners

Not all countries are affected, but I couldn't find the root cause.
We will need a fix for this on 02.05. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This issue or pull request is open for general discussion type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants