Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly position notification for mobile #68

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Properly position notification for mobile #68

merged 1 commit into from
Jul 13, 2018

Conversation

hyjk2000
Copy link
Member

@hyjk2000 hyjk2000 commented Jul 3, 2018

Just noticed that the offline notification was not properly positioned on mobile. The top property should be overwritten for mobile in media query.

@hyjk2000 hyjk2000 added the bug label Jul 3, 2018
@hyjk2000 hyjk2000 requested a review from just4fun July 3, 2018 08:22
just4fun
just4fun approved these changes Jul 13, 2018
View reviewed changes
Copy link
Member

@just4fun just4fun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the offline tip is located in the bottom? Seems good to me.

@just4fun
Copy link
Member

tenor-73034601

@just4fun just4fun merged commit 6bf737e into master Jul 13, 2018
@hyjk2000
Copy link
Member Author

@just4fun Yes, we put it at the bottom for mobile only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@just4fun just4fun just4fun approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyjk2000 @just4fun