Recorder #27

vevenom · 2017-04-05T15:50:30Z

No description provided.

…d data for Recorder; Added plots for fitness; Added parsing of .md file using Recorder;

…edtuples?

…g; Deleted plot functionality from the Recorder

…der; Added description to FunctionGenerator

anandtrex · 2017-04-06T21:04:56Z

bin/ltl-recfun-sa.py

@@ -0,0 +1,101 @@
+import os


So this file has to be removed, and the recorder added to all remaining bin/ltl-* files.

Done but I'm not sure I understand how to call the other binaries as I'm getting error:
NotStartedProperly("SCOOP was not started properly.\nBe sure to start your program with the '-m scoop' parameter. You can find further information in the documentation.",)

How do i use the "-m scoop" parameter? I added recorder to bin/ltl-* files but cannot test because of this

anandtrex · 2017-04-06T21:05:53Z

ltl/optimizees/functions/benchmarked_functions.py

+        function_name = self.function_names[ind]
+        return function, function_name
+
+    def __create_rastrigin__(self):


Double underscore is reserved for system methods and deliberate name mangling. Please use single under-score, prefix-only.

anandtrex · 2017-04-06T21:06:38Z

ltl/optimizees/functions/benchmarked_functions.py

+
+class BenchmarkedFunctions:
+    def __init__(self):
+        self.function_names = ["Rastrigin2d", "Chasm", "Shekel2d", "Michalewicz2d", "3Gaussians2d"]


We definitely need all the functions here, especially multi-dimensional versions of these functions.

I will need some time to do this

I think you can add this slowly. It doesn't have to be with this pull request.

anandtrex · 2017-04-06T21:08:16Z

ltl/optimizees/functions/benchmarked_functions.py

+class BenchmarkedFunctions:
+    def __init__(self):
+        self.function_names = ["Rastrigin2d", "Chasm", "Shekel2d", "Michalewicz2d", "3Gaussians2d"]
+        self.functions = [self.__create_rastrigin__, self.__create_chasm__, self.__create_shekel__,


Why not just use a list of tuples? Your get_function_by_index will be even simpler then:

def get_function_by_index(self, ind): return function_name_map[ind]

anandtrex · 2017-04-06T21:09:27Z

ltl/optimizees/functions/function_generator.py

@@ -36,9 +36,15 @@ def __init__(self, fg_params, dims=2, bound=None, noise=False, mu=0., sigma=0.01
        self.gen_functions = []
        # The class name of the parameter named tuple indexes the actual function class,
        # which is initialized using the given param and dims
+        self.description = ""


Don't generate string here. You should use Jinja for this part too.
Why not just pass it as a dict all the way to the recorder and plug it into the jinja template you have?

Done. But now I need a way to record all optimizee parameters. Dimensionality and noise is fine but I had to add names and params of the involved functions as the member attributes of the FunctionGenerator class although I only need this for the recorder

anandtrex · 2017-04-06T21:10:49Z

postproc/recorder.py

@@ -0,0 +1,108 @@
+from git import Repo
+import datetime
+from jinja2 import Environment, FileSystemLoader


Should add jinja2 and PythonGit to requirements.txt (with correct pypi package names)

anandtrex · 2017-04-06T21:12:59Z

postproc/recorder.py

+        self.runtime = self.end_time - self.start_time
+        self.__parse_md__()
+
+    def __parse_md__(self):


Ditto comment about double underscores.

anandtrex · 2017-04-06T21:19:25Z

postproc/recorder.py

+    def __init__(self, environment,
+                 optimizee_id, optimizee_name, optimizee_description, optimizer_name, optimizer_parameters):
+        self.record_flag, self.username, self.description = self.__process_args__()
+        self.environment = environment


Why not pass the trajectory directly?

anandtrex · 2017-04-06T21:20:54Z

postproc/recorder.py

+        template = env.get_template("md-template.jinja")
+        with open(fname, 'w') as f:
+            rendered_data = template.render(context)
+            f.write(rendered_data)


You should print a message here to logger.info saying the details have been recorded in this particular file in the particular path.

…ocess list of namedtuples directly; Add recorder functionality to bin files; Removed ltl-recfun-sa.py as it was only for testing;

anandtrex

Two very minor comments. Otherwise looks good. Will merge in once the two are taken care of.

anandtrex · 2017-04-11T15:37:47Z

bin/ltl-fun-ce.py

+    # Add Recorder
+    recorder = Recorder(trajectory=traj, optimizee_id=function_id,
+                        optimizee_name=fg_name, optimizee_parameters=fg_instance,
+                        optimizer_name=parameters.__class__.__name__, optimizer_parameters=parameters)


Wouldn't parameters.__class__.__name__ give the class name of the Optimizer parameters named tuple? Should this be optimizer.__class__.__name__?

anandtrex · 2017-04-11T15:43:28Z

bin/ltl-fun-ce.py

@@ -53,12 +56,18 @@ def main():
    # Get the trajectory from the environment
    traj = env.trajectory

+    function_id = 4
+    bench_functs = BenchmarkedFunctions(noise=True)
+    fg_name, fg_instance = bench_functs.get_function_by_index(4)


Should be fg_params instead of fg_instance .

…ed in bin/* files optimizer_name=optimizer.__class__.__name__

vevenom · 2017-04-11T16:14:54Z

I also added quickly some benchmark functions and also multidimensionals. This should server as the basis for the future benchmark functions. For some the parameters need to change in order to have nice 10d representation so I did not add those. Maybe you should rerun test on ...-ce and ...-face bin files as I am not sure how to run them with right flags

anandtrex · 2017-04-11T16:48:10Z

Ok.
Sorry I just remembered one more thing you need to do before a merge: Can you add a section to the documentation (doc/intro.rst) describing how to use the recorder?

anandtrex · 2017-04-11T22:48:01Z

Sorry looks like I missed this comment earlier. You really run the script with -m scoop. So for example, you would run `python -m scoop bin/ltl-recfun-sa.py` See http://scoop.readthedocs.io/en/0.7/usage.html#how-to-launch-scoop-programs for more details.

…

On Tue, Apr 11, 2017 at 5:00 PM, sinisastekovic ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In bin/ltl-recfun-sa.py <#27 (comment)>: > @@ -0,0 +1,101 @@ +import os Done but I'm not sure I understand how to call the other binaries as I'm getting error: NotStartedProperly("SCOOP was not started properly.\nBe sure to start your program with the '-m scoop' parameter. You can find further information in the documentation.",) How do i use the "-m scoop" parameter? I added recorder to bin/ltl-* files but cannot test because of this — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#27 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABxZ3xNiUH2I1cBVQnc54kQmFTjmzOIRks5ru5WggaJpZM4M0coT> .

…r in intro.rst; Added handling of class parameters for optimizee function description and parameters of the optimizers

vevenom · 2017-04-12T15:51:35Z

Ok, that should be it. Added the functionality for ce and face and tested it. There the parameters of optimizer can be instance of some class so I added a handle for it. Added a section in intro.rst

anandtrex · 2017-04-12T17:03:37Z

bin/ltl-fun-ce.py

@@ -19,7 +19,7 @@

 def main():
    name = 'LTL-FUN-CE'
-    root_dir_path = None  # CHANGE THIS to the directory where your simulation results are contained
+    root_dir_path = "/home/sinisa/ltlresults/"  # CHANGE THIS to the directory where your simulation results are contained


Yay, forgot that. Fixed :)

anandtrex · 2017-04-13T11:58:17Z

Merged! I did a squash merge, so you might want to continue development off master and not continue on the recorder branch.

vevenom added 26 commits April 5, 2017 16:02

Added Recorder framework; Added git check

487090e

Added git id to Recorder

2be1eb3

Fixed git id attribute

a73c022

Added optimizer optimizee to Recorder

b8ebb0f

Testing with ltl-recfun-sa.py

25d1943

Added template file for Recorder; Added functionality to record neede…

64225df

…d data for Recorder; Added plots for fitness; Added parsing of .md file using Recorder;

Added documentation;Fixed code style; What to do with _asdict for nam…

8a8a7bd

…edtuples?

Added final_fitness, final_individual to the trajectory

39a1143

Added n_iterations to Recorder and to trajectory in simulatedannealin…

a7c2aaa

…g; Deleted plot functionality from the Recorder

Removed random exception handling

d6e4bf6

Code cleanup

028c793

Added username; Added argparse

eaafd25

Fixed description

0cfbdfc

Added number of iterations in simulatedannealing is self.g + 1

6fa2fb9

Style check

fe89b7f

Changed bin/ltl-recfun-sa.py to work with rebased master

96fe70a

Quick fix for ltl-recfun-sa.py

1795df0

Change n of iterations to 10 for ltl-recfun-sa.py for testing

c504fca

Added adjust final_individual, final_fitness to rebased version

0b3cf20

Quick fix

963c382

Added recorder_flag functionality

d2fbfa3

Fixed recorder flag

5aa2e41

Undo root_dir_path

1986e7c

Style check

175f6bb

Added BenachmarkedFunctions; Added id, optimizee_description to recor…

33db50b

…der; Added description to FunctionGenerator

Style check

444d5c9

vevenom requested a review from anandtrex April 6, 2017 14:03

Updated docstring for recorder

e1e3d3b

anandtrex suggested changes Apr 6, 2017

View reviewed changes

anandtrex mentioned this pull request Apr 6, 2017

Mechanism to record results #21

Closed

vevenom added 5 commits April 11, 2017 16:59

Removed description from FunctionGenerator; Changed md-template to pr…

76fed0f

…ocess list of namedtuples directly; Add recorder functionality to bin files; Removed ltl-recfun-sa.py as it was only for testing;

Quick fix

225a2ff

Added recorder log message

4bb01ba

Added jinja2 and gitpython to requirements

e006d3a

Style check

56576a4

anandtrex approved these changes Apr 11, 2017

View reviewed changes

vevenom added 3 commits April 11, 2017 17:55

Added some benchmark functions

e2aaa05

Added some benchmark functions; Fixed fg_instance to fg_params; Chang…

223dc4c

…ed in bin/* files optimizer_name=optimizer.__class__.__name__

Quick fix

f0b2703

vevenom added 3 commits April 12, 2017 17:43

Added and tested recording for face and ce; Added section for recorde…

0badfb9

…r in intro.rst; Added handling of class parameters for optimizee function description and parameters of the optimizers

Quick additional fix

039c46b

Style check

6aa9ee2

anandtrex approved these changes Apr 12, 2017

View reviewed changes

vevenom and others added 2 commits April 13, 2017 12:48

Quick fix

92f2d90

Merge branch 'master' into recorder

3ac91f2

anandtrex merged commit 7134723 into master Apr 13, 2017

anandtrex deleted the recorder branch April 13, 2017 11:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Recorder #27

Recorder #27

vevenom commented Apr 5, 2017

anandtrex Apr 6, 2017

vevenom Apr 11, 2017

anandtrex Apr 6, 2017

vevenom Apr 11, 2017

anandtrex Apr 6, 2017

vevenom Apr 11, 2017

anandtrex Apr 11, 2017

anandtrex Apr 6, 2017

vevenom Apr 11, 2017

anandtrex Apr 6, 2017

vevenom Apr 11, 2017

anandtrex Apr 6, 2017

vevenom Apr 11, 2017

anandtrex Apr 6, 2017

vevenom Apr 11, 2017

anandtrex Apr 6, 2017

vevenom Apr 11, 2017

anandtrex Apr 6, 2017

vevenom Apr 11, 2017

anandtrex left a comment

anandtrex Apr 11, 2017

vevenom Apr 11, 2017

anandtrex Apr 11, 2017

vevenom Apr 11, 2017

vevenom commented Apr 11, 2017 •

edited

Loading

anandtrex commented Apr 11, 2017

anandtrex commented Apr 11, 2017 via email

vevenom commented Apr 12, 2017

anandtrex Apr 12, 2017

vevenom Apr 13, 2017

anandtrex commented Apr 13, 2017

Recorder #27

Recorder #27

Conversation

vevenom commented Apr 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anandtrex left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vevenom commented Apr 11, 2017 • edited Loading

anandtrex commented Apr 11, 2017

anandtrex commented Apr 11, 2017 via email

vevenom commented Apr 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anandtrex commented Apr 13, 2017

vevenom commented Apr 11, 2017 •

edited

Loading