Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong device error created by a breaking change in torch when using DDP #120

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Fix wrong device error created by a breaking change in torch when using DDP #120

merged 2 commits into from
Apr 24, 2024

Conversation

CharlesGaydon
Copy link
Collaborator

Cf. #119

leavauchier
leavauchier requested changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@leavauchier leavauchier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to rebase on main and update version in myria3d/_version.py. But all the rest looks ok to me

@leavauchier leavauchier merged commit 5f876d6 into main Apr 24, 2024
2 checks passed
@leavauchier leavauchier deleted the 119-fix-ddp-regression branch April 24, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leavauchier leavauchier leavauchier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CharlesGaydon @leavauchier