Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Abandon of option to get circular patches since it was never used #88

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

CharlesGaydon
Copy link
Collaborator

@CharlesGaydon CharlesGaydon commented Oct 4, 2023

cf. #65

A merge après #87

@CharlesGaydon CharlesGaydon changed the base branch from dev to main October 4, 2023 13:25
@CharlesGaydon CharlesGaydon added the refactor Cleaning, refactoring, simplifying. label Oct 4, 2023
Copy link
Collaborator

@leavauchier leavauchier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

il semble y avoir du linting qui a été appliqué sur du code qui n'est pas directement lié à cette MR
mais sinon ça me semble ok

@CharlesGaydon CharlesGaydon force-pushed the 65-2-remove-circular-patches branch 2 times, most recently from f47f821 to ce5fb26 Compare October 12, 2023 14:22
subtile_overlap_train: Number = 0,
subtile_overlap_predict: Number = 0,
batch_size: int = 12,
num_workers: int = 1,
prefetch_factor: int = 2,
transforms: Optional[Dict[str, TRANSFORMS_LIST]] = None,
**kwargs,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to ensure backward compatibility, but was not tested with older configs.

@CharlesGaydon CharlesGaydon merged commit 0c528d3 into main Oct 12, 2023
1 check passed
@CharlesGaydon CharlesGaydon deleted the 65-2-remove-circular-patches branch October 12, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Cleaning, refactoring, simplifying.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants