fix SEX to SDV #34
fix SEX to SDV #34
Conversation
|
let me ask Luke to approve and see if that works. |
|
I tried again approving with a comment and that still didn't work.
…On Tue, Jun 6, 2023 at 8:04 AM John Moehrke ***@***.***> wrote:
let me ask Luke to approve and see if that works.
—
Reply to this email directly, view it on GitHub
<#34 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACLPBGUTELDQSNNVHSRBXALXJ5BHLANCNFSM6AAAAAAY4QDC3Y>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
@lukeaduncan strange branch control is happening. I requested Mohammad to approve, he did, but that didn't unblock the pull-request. Given that this is the new branch control we are using in IHE, I want to figure out what is not working. So please approve, and we will see if YOUR permissions unblocks the pull request. |
|
note.. I know that I can override the block... but want to figure out the right thing as not all committees have a user with the authority that I have. |
|
so, somehow luke is more powerful than Mohammad. |
It looks like it was saying it needed a review by someone with write access. I don't know if that was a difference or not. |
|
Interesting. I wonder if I have write access to this repo. Luke’s approval
unblocked the merge.
…On Tue, Jun 6, 2023 at 5:22 PM John Moehrke ***@***.***> wrote:
note.. I know that I can override the block... but want to figure out the
right thing as not all committees have a user with the authority that I
have.
—
Reply to this email directly, view it on GitHub
<#34 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACLPBGWO6EF5JGPX5KKQMO3XJ5DLJANCNFSM6AAAAAAY4QDC3Y>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
I ddin't see in the branch control where it requires a review of someone with write... that might be a problem with our plan on branch control. or do we want co-chairs to approve everything? |
close #33