Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos in ITI-18 #138

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Conversation

qligier
Copy link
Contributor

@qligier qligier commented Mar 2, 2022

This commit fixes some typos spotted in the ITI-18 specifications.

Copy link
Contributor

@JohnMoehrke JohnMoehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Likely more span can be removed. Would prefer just XMLname class with no span.

@qligier
Copy link
Contributor Author

qligier commented Mar 2, 2022

Sure, I removed only a couple of spans because it introduced white spaces in the quotes, but there's a lot of cleanup that could be done.

@JohnMoehrke
Copy link
Contributor

Sure, I removed only a couple of spans because it introduced white spaces in the quotes, but there's a lot of cleanup that could be done.

Yes, that is what that other issue that you commented on is all about. Cleanup, the transition from WORD to html was messy in ways that are not helpful to maintaining the html. So, this PR is good. but if you want to further refine you can. you could also attack any file and remove unnecessary span under the issue #44.

really appreciate your help.

@qligier
Copy link
Contributor Author

qligier commented Mar 2, 2022

I can spend a bit of time to clean this page. I suggest merging this PR as-is because it was focused on typos; I'll open a new one with the broader cleaning, with each fix in its own commit so it can either be merged as a whole or cherry-picked.

@JohnMoehrke
Copy link
Contributor

yes. I agree. ITI will be meeting on monday to look at these PR

@JohnMoehrke JohnMoehrke merged commit b9f9eb1 into IHE:master Mar 7, 2022
@qligier qligier deleted the fix-iti18-typos branch March 7, 2022 16:38
@JohnMoehrke
Copy link
Contributor

Committee reviewed and approved

closed #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants