Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we alias @none to none (or similar)? #1739

Closed
jpstroop opened this issue Dec 3, 2018 · 10 comments
Closed

Should we alias @none to none (or similar)? #1739

jpstroop opened this issue Dec 3, 2018 · 10 comments
Assignees
Labels
Approved-by-TRC Issue has been approved by the TRC normative presentation Ready-for-Eds Editorial changes ready for Editorial review

Comments

@jpstroop
Copy link
Member

jpstroop commented Dec 3, 2018

[from Rob]
The advantage of the language map pattern is you can do manifest.label.en to get the english labels for the manifest. We can't do that for no language without using the disliked ['@none'] pattern. Thus we should alias @none to something and discuss with JSON-LD WG if there's a best practice here

@azaroth42
Copy link
Member

azaroth42 commented Dec 4, 2018

We /can/ - see json-ld playground: http://tinyurl.com/yd2v4mlu
I think we also should.

@zimeon
Copy link
Member

zimeon commented Dec 4, 2018

If we decide to alias I would be tempted towards @azaroth42's noLanguage in the playground example in preference to none

@azaroth42 azaroth42 changed the title Can we alias @none to none? Should we alias @none to none (or similar)? Dec 5, 2018
@azaroth42
Copy link
Member

azaroth42 commented Dec 5, 2018

Question - can we use scoped contexts to add the alias for @none ONLY within the properties that take a language?

Answer - Yes, and probably should: http://tinyurl.com/yd7cnfe7

@tomcrane
Copy link
Contributor

tomcrane commented Dec 5, 2018

👍 to "none"

@azaroth42
Copy link
Member

Raised upstream clarification issue about the definition of @none in JSON-LD: w3c/json-ld-syntax#102

@mikeapp
Copy link
Member

mikeapp commented Dec 5, 2018

👍 to none

@zimeon
Copy link
Member

zimeon commented Dec 5, 2018

Given (hopeful) clarification of JSON-LD description of @none to mean more than just "no language", I'm 👍 on none

@azaroth42
Copy link
Member

So proposal from the editors is to alias @none as none using scoped contexts such that it only affects the language map properties.

@azaroth42 azaroth42 added Ready-for-TRC Normative changes ready for TRC review and removed discuss labels Jan 8, 2019
@christopher-johnson
Copy link

christopher-johnson commented Jan 9, 2019

👍 to none. This also facilitates GraphQL (it cannot query fields with @).

@azaroth42 azaroth42 self-assigned this Jan 23, 2019
@zimeon zimeon added Approved-by-TRC Issue has been approved by the TRC and removed Ready-for-TRC Normative changes ready for TRC review labels Feb 27, 2019
@azaroth42 azaroth42 added the Ready-for-Eds Editorial changes ready for Editorial review label Apr 15, 2019
@zimeon
Copy link
Member

zimeon commented Apr 16, 2019

none issues addressed by merge of #1810, the question os en-us split off into #1771. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-by-TRC Issue has been approved by the TRC normative presentation Ready-for-Eds Editorial changes ready for Editorial review
Projects
None yet
Development

No branches or pull requests

6 participants