Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'w,h' as canonical size param vs. compliance level requirements #1785

Closed
lutzhelm opened this issue Mar 6, 2019 · 6 comments · Fixed by #1799
Closed

'w,h' as canonical size param vs. compliance level requirements #1785

lutzhelm opened this issue Mar 6, 2019 · 6 comments · Fixed by #1799
Assignees
Labels
Approved-by-TRC Issue has been approved by the TRC image normative

Comments

@lutzhelm
Copy link
Contributor

lutzhelm commented Mar 6, 2019

Version 3 will have w,has the canonical size URI parameter syntax, but arbitrary w,h requests are only required for level 2 compliance. So at level 1, servers are able to serve tiles proportionally scaled to an arbitrary width or arbitrary height, but if clients want to use that feature, they can't use the canonical URI syntax. So if clients want to request tiles via canonical URIs, they can only request them for the listed tiles / scalefactors. If no tiles are given in the info.json, requests for tiles to level 1 services can't be done in canonical form. Same applies to sizes.

On the other hand, having w,h required for level 1 would require those image servers to also serve non proportionally scaled images.

@lutzhelm
Copy link
Contributor Author

lutzhelm commented Mar 6, 2019

See also #301 and #544

@tomcrane
Copy link
Contributor

tomcrane commented Mar 6, 2019

For clarity, this issue refers to this table in the compliance level document:

https://preview.iiif.io/api/image-prezi-rc2/api/image/3.0/compliance/#32-size

The suggestion is that this table is wrong, and that REQUIRED should be for the now-canonical w,h form, and not for the w, and ,h forms.

@jpstroop
Copy link
Member

jpstroop commented Mar 6, 2019

I feel like we did discuss this at some point, but we must have lost the thread, unless I'm remembering all the way back to the issues @lutzhelm references above, which seems unlikely. I can't think of a reason why @tomcrane's solution isn't the best way to correct for this.

@zimeon
Copy link
Member

zimeon commented Mar 6, 2019

If we add REQUIRED for w,h, I don't see any reason not to leave REQUIRED also for w, and ,h. Implementation would likely just translate a w, or ,h to a w,h internally so it places no additional burden regarding image manipulation. Leaving those as required is less churn from v2 too.

However, as @lutzhelm points out, making w,h REQUIRED does imply distorting scaling at level 1. Following on from #879 discussion, I don't really think this is an issue. Do we know of a case where it would be?

@zimeon
Copy link
Member

zimeon commented Apr 15, 2019

Editors agree that we need to add w,h as REQUIRED at level1, also leave w, and ,h as REQUIRED -- change to https://preview.iiif.io/api/image-prezi-rc2/api/image/3.0/compliance/#32-size

@zimeon
Copy link
Member

zimeon commented May 9, 2019

IIIF/trc#18 approved, we can move ahead with merging #1799

@zimeon zimeon added Approved-by-TRC Issue has been approved by the TRC and removed Ready-for-TRC Normative changes ready for TRC review labels May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-by-TRC Issue has been approved by the TRC image normative
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants