Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider, change logo to 1:1 #1699

Merged
merged 3 commits into from
Nov 12, 2018
Merged

Add provider, change logo to 1:1 #1699

merged 3 commits into from
Nov 12, 2018

Conversation

azaroth42
Copy link
Member

@azaroth42 azaroth42 commented Oct 17, 2018

@azaroth42
Copy link
Member Author

Ping @jpstroop @tomcrane


The value _MUST_ be an array of JSON objects, each of which _MUST_ have an `id` and _SHOULD_ have at least one of `type` and `format`.
The value _MUST_ be a JSON objects, which _MUST_ have an `id` and _SHOULD_ have at least one of `type` and `format`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The value _MUST_ be a JSON objects, which _MUST_ have an `id` and _SHOULD_ have at least one of `type` and `format`.
The value _MUST_ be a JSON object, which _MUST_ have an `id` and _SHOULD_ have at least one of `type` and `format`.

@azaroth42 azaroth42 changed the title Add provider, change logo to 1:1 [DNM] Add provider, change logo to 1:1 Nov 3, 2018
@azaroth42
Copy link
Member Author

Missing update to the summary tables - DNM

@azaroth42 azaroth42 changed the title [DNM] Add provider, change logo to 1:1 Add provider, change logo to 1:1 Nov 3, 2018
@@ -265,6 +265,57 @@ The value _MUST_ be a string. If the value is drawn from Creative Commons or Rig
{ "rights": "https://creativecommons.org/licenses/by/4.0/" }
```

##### provider

An organization or person that contributed to providing the content of the resource. Clients can then display this information to the user to acknowledge the provider's contributions. This differs from the `requiredStatement` property, in that the data is structured, allowing the client to do more than just present text but instead have richer information about the people and organizations to use in different interfaces.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should "can then" be MAY ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's SHOULD in the normative part for Collection and Manifest. "can" was intentionally chosen to NOT seem like an RFC word.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'm stuck with the old fashioned British permission/ability distinction between may/can ;-) I don't see a simple change so I'll 👍

@jpstroop jpstroop merged commit 608642d into image-prezi-rc2 Nov 12, 2018
@jpstroop jpstroop deleted the 1639-provider branch November 12, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants