added /postvalidate route for JSON POST validation #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -113,7 +136,8 @@ def do_test(self): | |||
| return self.format_response(infojson, fmt) | |||
|
|
|||
| def dispatch_views(self): | |||
| self.app.route("/validate", "GET", self.do_test) | |||
| self.app.route("/validate", "GET", self.do_GET_test) | |||
| self.app.route("/postvalidate", "POST", self.do_POST_test) | |||
There was a problem hiding this comment.
What about just POSTing to /validate ? No need to introduce a new URI?
There was a problem hiding this comment.
Sure, understood.
|
Merged, thanks @calvinbutcher! |
|
Thanks, @calvinbutcher, this is very useful! I have a couple of issues/questions about this:
|
|
1 would be because the new code isn't deployed yet :) I expect that 2 is that the JSON is in the body of the POST, rather than web form encoded. |
|
Thanks, Rob! Please let me know when it's deployed by commenting here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New "/postvalidate" route receives POST of JSON body-text with a Content-Type:application/json. Responds with JSON returning the received data, an okay flag, warnings, and errors.