Invalid font color with Breeze Dark theme

[vanyasem]

I am running Arch GNU/Linux with KDE Plasma 5.11.4 (Qt 5.10.0)

I am using a dark theme (Breeze Dark), but unfortunately some fonts are rendered incorrectly and are impossible to read.

I tried both installing the package from repos and compiling it myself.

[daveol]

The same issue arises by enabling the "Global Dark Theme" in gnome 3 on fedora

[annejan]

This should probably only use native theme colours instead of hardcoded colours.

[Piraty]

I can add to this.
In most parts of qtpass my dark theme is respected in terms of color inversion, but not on "welcome screen".

Image shows qtpass-1.2.3
I suspect the text colors are hardcoded. yes, they are:

QtPass/src/mainwindow.ui

Lines 242 to 251 in cc29730

	<property name="html">
	<string>&lt;!DOCTYPE HTML PUBLIC &quot;-//W3C//DTD HTML 4.0//EN&quot; &quot;http://www.w3.org/TR/REC-html40/strict.dtd&quot;&gt;
	&lt;html&gt;&lt;head&gt;&lt;meta name=&quot;qrichtext&quot; content=&quot;1&quot; /&gt;&lt;style type=&quot;text/css&quot;&gt;
	p, li { white-space: pre-wrap; }
	&lt;/style&gt;&lt;/head&gt;&lt;body style=&quot; font-family:'Cantarell'; font-size:11pt; font-weight:400; font-style:normal;&quot;&gt;
	&lt;p style=&quot; margin-top:12px; margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;&quot;&gt;&lt;span style=&quot; font-family:'Helvetica Neue,Helvetica,Segoe UI,Arial,freesans,sans-serif'; font-size:13pt; font-weight:600; color:#333333;&quot;&gt;QtPass&lt;/span&gt;&lt;span style=&quot; font-family:'Helvetica Neue,Helvetica,Segoe UI,Arial,freesans,sans-serif'; font-size:13pt; color:#333333;&quot;&gt; is a GUI for &lt;/span&gt;&lt;a href=&quot;https://www.passwordstore.org/&quot;&gt;&lt;span style=&quot; font-family:'Helvetica Neue,Helvetica,Segoe UI,Arial,freesans,sans-serif'; font-size:13pt; text-decoration: underline; color:#4183c4; background-color:transparent;&quot;&gt;pass&lt;/span&gt;&lt;/a&gt;&lt;span style=&quot; font-family:'Helvetica Neue,Helvetica,Segoe UI,Arial,freesans,sans-serif'; font-size:13pt; color:#333333;&quot;&gt;, the standard unix password manager.&lt;/span&gt;&lt;/p&gt;
	&lt;p style=&quot; margin-top:12px; margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;&quot;&gt;&lt;span style=&quot; font-family:'Helvetica Neue,Helvetica,Segoe UI,Arial,freesans,sans-serif'; font-size:13pt; color:#333333;&quot;&gt;&lt;br /&gt;Please report any &lt;/span&gt;&lt;a href=&quot;https://github.com/IJHack/qtpass/issues&quot;&gt;&lt;span style=&quot; font-family:'Helvetica Neue,Helvetica,Segoe UI,Arial,freesans,sans-serif'; font-size:13pt; text-decoration: underline; color:#4183c4;&quot;&gt;issues&lt;/span&gt;&lt;/a&gt;&lt;span style=&quot; font-family:'Helvetica Neue,Helvetica,Segoe UI,Arial,freesans,sans-serif'; font-size:13pt; color:#333333;&quot;&gt; you might have with this software.&lt;/span&gt;&lt;/p&gt;
	&lt;p style=&quot; margin-top:12px; margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;&quot;&gt;&lt;a href=&quot;https://qtpass.org/&quot;&gt;&lt;span style=&quot; font-family:'Helvetica Neue,Helvetica,Segoe UI,Arial,freesans,sans-serif'; font-size:13pt; text-decoration: underline; color:#4183c4; background-color:transparent;&quot;&gt;Documentation&lt;/span&gt;&lt;/a&gt;&lt;/p&gt;
	&lt;p style=&quot; margin-top:12px; margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;&quot;&gt;&lt;a href=&quot;https://github.com/IJHack/qtpass&quot;&gt;&lt;span style=&quot; font-family:'Noto Sans'; font-size:12pt; text-decoration: underline; color:#4183c4;&quot;&gt;SourceCode&lt;/span&gt;&lt;/a&gt;&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
	</property>

and a few other localization/localization_xx_XX.ts files

[annejan]

Same issue with macOS Mojave

Qt is working on some of the issues, the rest might be easily fixable with some style changes.

[annejan]

Fixed the HTML

I don't like the blue, but I like adding hardcoded styles even less . .

Testing on KDE Breeze Dark asap 😸

[alxlg]

Can you please use system colors and not hard code any color?

[a-andreyev]

Hello! Thanks for the handy app!
Looks like it's possible just to drop the hardcoded color:#0000ff value at the src/configdialog.ui and src/mainwindow.ui to fix the issue, am I right? 🤔
Checking with Qt 5.13, KDE Plasma 5.16 (yet another arch fanboy), looks like html without specified color renders correctly according to the system-wide theme? (For example, at the config dialog version info)

[pheraph]

I still see this problem on macOS (QtPass 1.3.2). 🧐

[Piraty]

the dark blue hyperlink color seems to be inherited from system/qt, since i have that in quiet a lot applications (along: texstudio, quassel), so i suspect a general theming issue

[annejan]

This does not seem to be the case this time @Piraty

I have sanitised the HTML content of the start screen.
Unfortunately QtCreator automagically places <span> the markup back . . @Piraty was right after all 😉

So I edited the mainwindow.ui file and replaced the HTML for clean HTML . .

Now it looks like this (macOS dark) . .

So no improvement there . . except for size and spacing 😞

[annejan]

I'm taking this up with Qt . . Along with the inherited transparency of context menu's . .