Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html links color and NL translation building error #476

Merged
merged 2 commits into from Sep 26, 2019

Conversation

@a-andreyev
Copy link
Contributor

@a-andreyev a-andreyev commented Sep 25, 2019

Fixes #340
Result is system theme link highlight color:
imgur

Also faced building error via archlinux AUR qtpass-git:
looks like lrelease generates localization/localization_nl_BE.qm and localization/localization_nl_NL.qm even from localization_nl.qm, so I updated qrc list (could be wrong, but working for me 馃 )

@coveralls
Copy link

@coveralls coveralls commented Sep 25, 2019

Coverage Status

Coverage increased (+0.02%) to 6.96% when pulling 29e65d7 on a-andreyev:aa13q/fix-html-links-font-color into 9e73083 on IJHack:master.

@annejan annejan merged commit bb4d3ec into IJHack:master Sep 26, 2019
2 of 3 checks passed
@annejan
Copy link
Member

@annejan annejan commented Sep 26, 2019

Thanks for the colour fix . .

The translation thing works for me too (had to switch to Dutch to test 馃槈)

@annejan
Copy link
Member

@annejan annejan commented Sep 26, 2019

Interestingly enough the two nl_NL.ts and nl_BE.ts files get generated from the one nl.ts

So I'll just replace the one with the two in a later commit 馃槒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants