New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear text input: use system icon instead of x #84

Closed
lightonflux opened this Issue Aug 3, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@lightonflux

lightonflux commented Aug 3, 2015

I guess this just happened because something had to be in the button, and a label would be too big. Right?

It looks rather prototypy:

bildschirmfoto vom 2015-08-04 00 58 36

Instead the system icon for "clear" should be used. Or better an inline x within the input box.¹ Or even more awesome and better: the inline clear icon of the system/toolkit.

Example (sorry, dark theme):

bildschirmfoto vom 2015-08-04 01 12 27

1: as known from mobile websites and mobile safari

BTW: Just looked at my desktop apps (~120) and qtpass is the only one with a clear button

Oh look, you don't have to do it yourself: https://doc.qt.io/archives/qt-4.7/declarative-ui-components-searchbox.html

Other password managers like keepassx, keepass and last past choose another option. No clear functionality at all.

Source: quick google image search

@annejan annejan self-assigned this Aug 3, 2015

@annejan

This comment has been minimized.

Member

annejan commented Aug 3, 2015

Nice one . .
Will have to find or design a button image that works on (just about) every theme. I'm thinking white border around a black X.
Since apparently there is no system default button/widget available cross-platform and wm in Qt.
It should be used for the main app search box too.

@lightonflux

This comment has been minimized.

lightonflux commented Aug 3, 2015

Mozilla does a good job with Firefox's icons. Just don't take VLC or keepass as examples. :)

@annejan

This comment has been minimized.

Member

annejan commented Jan 23, 2016

This is (partially) fixed in #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment