New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv4 URLs are non-clickable #97

Closed
sjau opened this Issue Sep 11, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@sjau

sjau commented Sep 11, 2015

Hi there

if you have in a multiline-entry a URL with a domain name it's clickable. Nice to visit that page directly.
e.g. http://www.domain.tld

However if you have a URL with an IPv4 address (didn't test IPv6) then it's non clickable and just shows as text.
e.g. http://127.0.0.1

It would be great if IPv4/6 could also be clickable.

@annejan

This comment has been minimized.

Member

annejan commented Sep 11, 2015

The current QRegExp for url wrapping is: ((http|https|ftp)\\://[a-zA-Z0-9\\-\\.]+\\.[a-zA-Z]{2,3}(:[a-zA-Z0-9]*)?/?([a-zA-Z0-9\\-\\._\\?\\,\\'/\\\\+&%\\$#\\=~])*)

@annejan

This comment has been minimized.

Member

annejan commented Sep 24, 2015

Now replaced with ((?:https?|ftp)://\S+)

Fixed in master, should be in release 1.0.2 soon

annejan added a commit that referenced this issue Sep 24, 2015

@annejan annejan closed this Sep 24, 2015

@sjau

This comment has been minimized.

sjau commented Sep 25, 2015

Thanks for your hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment