Use --secure for pwgen and add more configurable options #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable --secure option for pwgen by default as it allows it to generate more random passwords. Also, add the following options to pwgen together with corresponding checkboxes: * --capitalize * --numerals * --secure All these options are enabled by default, as * we're a password manager, so no need to memorize passwords, so we should make them more secure by default; * most websites accept passwords, generated using these options (unlike --symbols option) Convert horizontal layout for options into form layout to accommodate more checkboxes.
|
Wow, that is a nice change-set. |
annejan
added a commit
that referenced
this pull request
Mar 6, 2016
Use --secure for pwgen and add more configurable options
|
Works great for me :) |
Thank you very much for very quick response and merge! |
annejan
added a commit
that referenced
this pull request
Jun 1, 2016
Use --secure for pwgen and add more configurable options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable --secure option for pwgen by default as it allows it
to generate more random passwords.
Also, add the following options to pwgen together with corresponding checkboxes:
All these options are enabled by default, as
so we should make them more secure by default;
(unlike --symbols option)
Convert horizontal layout for options into form layout
to accommodate more checkboxes.