Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --secure for pwgen and add more configurable options #168

Merged
merged 1 commit into from Mar 6, 2016
Merged

Use --secure for pwgen and add more configurable options #168

merged 1 commit into from Mar 6, 2016

Conversation

@ahippo
Copy link
Contributor

@ahippo ahippo commented Mar 6, 2016

Enable --secure option for pwgen by default as it allows it
to generate more random passwords.

Also, add the following options to pwgen together with corresponding checkboxes:

  • --capitalize
  • --numerals
  • --secure

All these options are enabled by default, as

  • we're a password manager, so no need to memorize passwords,
    so we should make them more secure by default;
  • most websites accept passwords, generated using these options
    (unlike --symbols option)

Convert horizontal layout for options into form layout
to accommodate more checkboxes.

Enable --secure option for pwgen by default as it allows it
to generate more random passwords.

Also, add the following options to pwgen together with corresponding checkboxes:
 * --capitalize
 * --numerals
 * --secure

All these options are enabled by default, as
 * we're a password manager, so no need to memorize passwords,
   so we should make them more secure by default;
 * most websites accept passwords, generated using these options
   (unlike --symbols option)

Convert horizontal layout for options into form layout
to accommodate more checkboxes.
@annejan
Copy link
Member

@annejan annejan commented Mar 6, 2016

Wow, that is a nice change-set.
Thanks for your effort!
Giving it a quick run before I merge.

annejan added a commit that referenced this pull request Mar 6, 2016
Use --secure for pwgen and add more configurable options
@annejan annejan merged commit 275da0a into IJHack:master Mar 6, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@annejan
Copy link
Member

@annejan annejan commented Mar 6, 2016

Works great for me :)

@ahippo
Copy link
Contributor Author

@ahippo ahippo commented Mar 6, 2016

Wow, that is a nice change-set.
Thanks for your effort!
Giving it a quick run before I merge.

Works great for me :)

Thank you very much for very quick response and merge!

annejan added a commit that referenced this pull request Jun 1, 2016
Use --secure for pwgen and add more configurable options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants