New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuing refactoring #407

Merged
merged 38 commits into from Sep 25, 2018

Conversation

Projects
None yet
5 participants
@FiloSpaTeam
Contributor

FiloSpaTeam commented Jul 23, 2018

What i'm trying to do:

  • MainWindow emit signal and connects various Dialog
  • QtPass class connect signal to Pass and various QtPassSettings

What i need to do:

  • Move mountWebDav inside QtPass class
  • Try to move outside checkConfig (or before MainWindow or later render)

FiloSpaTeam added some commits May 4, 2018

Converted most of Qt4 signals to Qt5 style. Fixed BUG with main folde…
…r hidden (possible regression for Windows users and dot folders)
Now qDebug enable only if QT_DEBUG is defined. Trying to refactoring …
…MainWindow - QtPass class should handle connecctions and business logic
@codecov

This comment has been minimized.

codecov bot commented Jul 24, 2018

Codecov Report

Merging #407 into master will increase coverage by 0.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #407      +/-   ##
=========================================
+ Coverage    6.46%   7.32%   +0.86%     
=========================================
  Files          39      41       +2     
  Lines        2585    2662      +77     
=========================================
+ Hits          167     195      +28     
- Misses       2418    2467      +49
Impacted Files Coverage Δ
src/mainwindow.h 0% <ø> (ø) ⬆️
src/mainwindow.cpp 0% <ø> (ø) ⬆️
src/pass.cpp 3.93% <ø> (+1.37%) ⬆️
src/usersdialog.h 0% <ø> (ø) ⬆️
main/main.cpp 0% <ø> (ø) ⬆️
src/qpushbuttonwithclipboard.h 0% <ø> (ø) ⬆️
src/configdialog.h 0% <ø> (ø) ⬆️
src/configdialog.cpp 0% <ø> (ø) ⬆️
src/qpushbuttonwithclipboard.cpp 0% <ø> (ø) ⬆️
src/usersdialog.cpp 0% <ø> (ø) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4dc9e6...5d5b266. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented Jul 24, 2018

Coverage Status

Coverage increased (+0.9%) to 7.306% when pulling 5d5b266 on UnitooTeam:master into b4dc9e6 on IJHack:master.

@annejan

This comment has been minimized.

Member

annejan commented Jul 24, 2018

Oh wow, those are nice changes . .

@FiloSpaTeam

This comment has been minimized.

Contributor

FiloSpaTeam commented Jul 24, 2018

Before merge i want to test more and try to do what i wrote above 👍

@annejan annejan added the refactoring label Jul 24, 2018

@annejan annejan self-requested a review Jul 24, 2018

FiloSpaTeam added some commits Jul 24, 2018

Trying to fix this BUG: when user switch profile and selectionModel h…
…as index, you can delete the key anyway
@annejan

annejan approved these changes Aug 7, 2018

@FiloSpaTeam

This comment has been minimized.

Contributor

FiloSpaTeam commented Aug 7, 2018

What do you think? :)

@FiloSpaTeam FiloSpaTeam force-pushed the UnitooTeam:master branch from 7b6f00a to 4009b82 Aug 8, 2018

@FiloSpaTeam

This comment has been minimized.

Contributor

FiloSpaTeam commented Aug 8, 2018

Travis CI build failed: possible this? -> -platform name

This command line argument applies to all Qt applications, but might be especially useful in the context of auto-testing. By using the "offscreen" platform plugin (-platform offscreen) it's possible to have tests that use QWidget or QWindow run without showing anything on the screen. Currently the offscreen platform plugin is only fully supported on X11.

Taken from https://doc.qt.io/qt-5/qtest-overview.html

@FiloSpaTeam

This comment has been minimized.

Contributor

FiloSpaTeam commented Aug 8, 2018

I've done a little rebase but for the other commits: it's a lot of work and i don't know finally if it can cause some troubles for the others and for the repo itself :~~
What do you think?

@annejan

This comment has been minimized.

Member

annejan commented Aug 8, 2018

I think I'll do some testing on some VMs tomorrow . .
Since I'm mostly doing data normalisation tasks I think I have time to do a lot of physical testing as-well.
On the rebasing . . I have no real opinion . .

FiloSpaTeam added some commits Aug 10, 2018

@annejan

This comment has been minimized.

Member

annejan commented Aug 14, 2018

I feel confident merging these changes . .

The only interesting thing I noticed is that the sorting order in the tree view is now z-a 😺

@FiloSpaTeam

This comment has been minimized.

Contributor

FiloSpaTeam commented Aug 14, 2018

LOL i didnt noticed. I ll see and fix anyway :) if you feel i need to change something tell

@FiloSpaTeam

This comment has been minimized.

Contributor

FiloSpaTeam commented Aug 17, 2018

Before merge i need to solve:

  • QTreeView sorting (however is Ascending...)
  • Fix a BUG when you type fast into lineEdit, sometimes root path is visible and random files are taken (this is present in the v1.2.3 too) xD
@FiloSpaTeam

This comment has been minimized.

Contributor

FiloSpaTeam commented Aug 17, 2018

To solve the second one, I created a Timer of 350ms that start on lineEdit changed and fire on timeout the real search event.

Another BUG, if selectionModel is empty and you click Enter you can delete the entire folder xD i'll check if selectionModel is selected

FiloSpaTeam added some commits Aug 17, 2018

Fixed BUG with empty name in profileTable. Fixed BUG when you remove …
…profile, profiles was not saved correctly. Adding timer to handle search (350ms).
Profile Table cell has red background whenn text is empty. Added some…
… tooltips for disabled checkbox like TrayIcon and OTP. Fixed Sort for QTreeView. Now when search is empty all QTreeView is collapsed and keys are not selected. Another fix when you press enter and proxyModel is empty.
@wamtek

This comment has been minimized.

wamtek commented Aug 24, 2018

@FiloSpaTeam It seems that something with the copy function is not working as expected in your version. After i decrypted an item from the list the password is automatically copied to the clipboard. But when i click on the copy symbol next to the password nothing happens. No matter if i try to copy the password or any other entry.
The unmodified version copies fine when clicking the symbol.

@FiloSpaTeam

This comment has been minimized.

Contributor

FiloSpaTeam commented Aug 24, 2018

Ok perfect, i'll fix it :) i didn t tried the copy button lol

FiloSpaTeam referenced this pull request Aug 28, 2018

@wamtek

This comment has been minimized.

wamtek commented Aug 29, 2018

Copy button works again. 👍

@annejan annejan merged commit 5d5b266 into IJHack:master Sep 25, 2018

3 of 4 checks passed

CodeFactor 1 issue found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment