Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes #413

Merged
merged 4 commits into from Sep 25, 2018
Merged

Bugfixes #413

merged 4 commits into from Sep 25, 2018

Conversation

@rdoeffinger
Copy link
Contributor

@rdoeffinger rdoeffinger commented Aug 25, 2018

No description provided.

rdoeffinger added 3 commits Aug 25, 2018
It causes a huge amount of completely irrelevant warnings
on that compiler.
No idea why "or" would work at all, but definitely
fails to compile on MSVC.
@rdoeffinger rdoeffinger force-pushed the rdoeffinger:bugfixes branch from 58825c2 to 04c9ca2 Aug 25, 2018
@codecov
Copy link

@codecov codecov bot commented Aug 25, 2018

Codecov Report

Merging #413 into master will decrease coverage by 0.58%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #413      +/-   ##
=========================================
- Coverage    6.46%   5.87%   -0.59%     
=========================================
  Files          39      39              
  Lines        2585    2586       +1     
=========================================
- Hits          167     152      -15     
- Misses       2418    2434      +16
Impacted Files Coverage Δ
src/qtpasssettings.h 0% <ø> (ø) ⬆️
src/mainwindow.cpp 0% <0%> (ø) ⬆️
src/executor.cpp 0% <0%> (-4.62%) ⬇️
src/qtpasssettings.cpp 0.9% <37.5%> (ø) ⬆️
src/simpletransaction.h 0% <0%> (-100%) ⬇️
src/realpass.h 0% <0%> (-100%) ⬇️
src/pass.h 0% <0%> (-50%) ⬇️
src/executor.h 0% <0%> (-50%) ⬇️
src/imitatepass.h 0% <0%> (-25%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4dc9e6...68490dc. Read the comment docs.

@coveralls
Copy link

@coveralls coveralls commented Aug 25, 2018

Coverage Status

Coverage decreased (-0.5%) to 5.893% when pulling 68490dc on rdoeffinger:bugfixes into b4dc9e6 on IJHack:master.

@@ -411,6 +411,9 @@ void MainWindow::config() {
this->show();

updateProfileBox();
// For freshStart, proxyModel is not yet configured
// and maniplating it will assert
if (!freshStart)
ui->treeView->setRootIndex(proxyModel.mapFromSource(

This comment has been minimized.

@lukedirtwalker

lukedirtwalker Sep 1, 2018
Contributor

Please indent the line after the if. Otherwise this looks very confusing.

mapFromSource can't be called when the proxyModel
has no source model set yet.
@rdoeffinger rdoeffinger force-pushed the rdoeffinger:bugfixes branch from 04c9ca2 to 68490dc Sep 5, 2018
@annejan annejan merged commit d5f9939 into IJHack:master Sep 25, 2018
6 checks passed
6 checks passed
CodeFactor No issues found.
Details
codecov/patch 25% of diff hit (target 6.46%)
Details
codecov/project Absolute coverage decreased by -0.58% but relative coverage increased by +18.53% compared to b4dc9e6
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linthub Linthub has cleared the pull request, no code style suggestions found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.