New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for using WSL binaries on Windows #431

Merged
merged 2 commits into from Dec 10, 2018

Conversation

Projects
None yet
3 participants
@rdoeffinger
Copy link
Contributor

rdoeffinger commented Nov 4, 2018

Uses WSL features to have the password store path automatically translated.

rdoeffinger added some commits Aug 29, 2018

Add support for using Linux binaries on Windows.
Uses WSL, selected by prefixing the binaries with "wsl ".
Automatically detect and use WSL binaries.
Treat WSL as if it contained binaries that are in the PATH.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 4, 2018

Codecov Report

Merging #431 into master will decrease coverage by 0.02%.
The diff coverage is 2.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #431      +/-   ##
=========================================
- Coverage    7.25%   7.22%   -0.03%     
=========================================
  Files          41      41              
  Lines        2662    2684      +22     
=========================================
+ Hits          193     194       +1     
- Misses       2469    2490      +21
Impacted Files Coverage Δ
src/executor.h 50% <ø> (ø) ⬆️
src/imitatepass.cpp 0.44% <0%> (-0.03%) ⬇️
src/executor.cpp 4.1% <0%> (-0.58%) ⬇️
src/configdialog.cpp 0% <0%> (ø) ⬆️
src/util.cpp 8.47% <0%> (-0.3%) ⬇️
src/pass.cpp 4.68% <50%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ea1ad...3b10fd3. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 4, 2018

Coverage Status

Coverage decreased (-0.02%) to 7.245% when pulling 3b10fd3 on rdoeffinger:wslsupport into 32ea1ad on IJHack:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 4, 2018

Coverage Status

Coverage decreased (-0.02%) to 7.245% when pulling 3b10fd3 on rdoeffinger:wslsupport into 32ea1ad on IJHack:master.

@annejan annejan merged commit 5918e60 into IJHack:master Dec 10, 2018

3 of 5 checks passed

codecov/patch 2.5% of diff hit (target 7.25%)
Details
codecov/project 7.22% (-0.03%) compared to 32ea1ad
Details
CodeFactor No issues found.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment