Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable out-of-source build #503

Merged
merged 3 commits into from
Jan 7, 2020
Merged

Enable out-of-source build #503

merged 3 commits into from
Jan 7, 2020

Conversation

boppybibbles
Copy link
Contributor

Closes #501.

@boppybibbles
Use new stable version of install-qt-action.
9e89a0e
@boppybibbles
Enable out-of-source builds.
7c5fa4e 
- Rely on `qmake`'s `CONFIG` to generate and embed QM files.
- Add all existing TS files to TRANSLATE.
- Keep TRANSLATE in single project file: `src/src.pro`.
- Update 'steps to translate' section in `CONTRIBUTING.md`.
@boppybibbles
Update all TS files because of changed source code.
7d873d8
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 7.084% when pulling 7d873d8 on boppybibbles:feature/enable-out-of-source-build into b0cdc00 on IJHack:master.

@codecov
Copy link

codecov bot commented Jan 4, 2020 •
edited
Loading

Codecov Report

Merging #503 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #503      +/-   ##
=========================================
- Coverage    9.36%   9.36%   -0.01%     
=========================================
  Files          46      46              
  Lines        2925    2926       +1     
=========================================
  Hits          274     274              
- Misses       2651    2652       +1
Impacted Files Coverage Δ
main/main.cpp 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0cdc00...7d873d8. Read the comment docs.

@annejan annejan merged commit e06f8d4 into IJHack:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable out-of-source (shadow) builds.
3 participants
@boppybibbles @coveralls @annejan