Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more options for the password displaying #587

Merged
merged 3 commits into from
Jan 28, 2023

Conversation

l3u
Copy link

@l3u l3u commented Feb 19, 2022

This addresses both issue #586 and issue #577.

I added two additional checkboxes to the configuration dialog:

  • "Use a monospace font" that, if activated, sets the system's default monospace font for both the QTextBrowser and all QLineEdits used to display password files
  • "Display the files content as-is" that, if activated, skips the parsing of the pass file content and simply puts everything into the QTextBrowser, as pass does when used on the console.

Imo this won't hurt, as the default behavior remains unchanged, but it's convenient for console pass users that want to have the same behavior in QtPass.

@l3u
Copy link
Author

l3u commented Feb 20, 2022

Just to say it: I adapted the way you did it, like

void QtPassSettings::setNoLineWrapping(const bool &noLineWrapping) {
  getInstance()->setValue(SettingsConstants::noLineWrapping, noLineWrapping);
}

but in such a case, it's not really meaningful to use a const reference to a bool value. The pointer to the bool value is bigger than the value itself, so it's actually worse than simply passing the variable by value ;-)

But this is another story …

@annejan annejan merged commit bc2c04c into IJHack:master Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants