Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 ikce 003 task001 user back end implementation #20

Merged

Conversation

anthonysasso2001
Copy link
Contributor

@anthonysasso2001 anthonysasso2001 commented Jul 4, 2024

Preliminary Info

  1. Connected issue ticket: IKCE-003_Task001
  2. Goal of merge request:
    • This PR is for adding user to backend
  3. Potential areas of concern/Issues
    • This may be limited by missing edge cases, did not get time to manually test queries but unit tests seem to look good.
    • This could cause issues with frontend work if I missed any edge cases.

Testing

Unit Tests & Coverage report screenshot

run npm run coverage and screenshot the final output (ex x of y covered) along with changed/added tests

image

Security Tests

screenshots of security test output from snyk test and snyk code test.

image

Examples

screenshot or screen-record any changes to the UI for altered components/css, or demo of any major functional changes if applicable.
N/A for back-end don't have time to run all manually atm due to time constraints on milestone 01.5

@anthonysasso2001 anthonysasso2001 linked an issue Jul 4, 2024 that may be closed by this pull request
@anthonysasso2001 anthonysasso2001 marked this pull request as draft July 4, 2024 14:51
@anthonysasso2001 anthonysasso2001 force-pushed the 11-ikce-003_task001-user-back-end-implementation branch from 9cfce89 to b46dddf Compare July 4, 2024 21:07
@anthonysasso2001 anthonysasso2001 marked this pull request as ready for review July 4, 2024 21:44
@anthonysasso2001 anthonysasso2001 merged commit 92ca5cc into master Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IKCE-003_Task001: User back-end implementation
3 participants